Project

General

Profile

Bug #3381

LAN interface root Queue Bandwidth calculation is exactly double the total of the other child queues

Added by Ignat Esso over 6 years ago. Updated about 1 month ago.

Status:
Feedback
Priority:
Normal
Category:
Traffic Shaper (ALTQ)
Target version:
Start date:
01/02/2014
Due date:
% Done:

100%

Estimated time:
Affected Version:
Affected Architecture:

Description

LAN interface root Queue Bandwidth calculation is exactly double the total of the other child queues. This looks to be having adverse effects on default queue dropping and borrowing from other queues.

Also at times the LAN totals are way out of whack i have the shaper set to 13.5 mbit and somehow the the totals exceed the total of bandwidth allocated. The root queue then doubles the totals of all child queues.

Attached Screenshot

pfsense_queues.PNG (26.7 KB) pfsense_queues.PNG Ignat Esso, 01/02/2014 08:25 PM

Associated revisions

Revision 40ce94b4 (diff)
Added by Viktor Gurov about 2 months ago

Status / Queues root queue bandwidth calculation fix. Issue #3381

History

#1 Updated by Ignat Esso over 6 years ago

FYI - The WAN interface seems to be 100% correct all the time.

#2 Updated by Ignat Esso over 6 years ago

Further to this, the " Borrow from other queues when available" doesn't work when you go 1 level deeper than the root.

LAN
qlink
qInternet(5mbit)
qDefault(50% of Parent (5Mbit))
qGames (25% of Parent (5Mbit))
qOther (25% of Parent (5Mbit))

When no other queues are used all traffic into qDefault yields 2.5Mbit even with the "Borrow from other queues when available" ticked.

It seems to work when the child queues are directly under the root queue

#3 Updated by Chris Buechler over 4 years ago

  • Category set to Traffic Shaper (ALTQ)

#4 Updated by Jure Wennekes over 4 years ago

The solution in this post has fixed the double count problem, seems to be a quick solution.

https://forum.pfsense.org/index.php?topic=76609.0

Credits go to confuseduser of course

#5 Updated by Viktor Gurov about 2 months ago

Ignat Esso wrote:

Further to this, the " Borrow from other queues when available" doesn't work when you go 1 level deeper than the root.

LAN
qlink
qInternet(5mbit)
qDefault(50% of Parent (5Mbit))
qGames (25% of Parent (5Mbit))
qOther (25% of Parent (5Mbit))

When no other queues are used all traffic into qDefault yields 2.5Mbit even with the "Borrow from other queues when available" ticked.

It seems to work when the child queues are directly under the root queue

This is FreeBSD issue:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155736

Unfortunately it seems that borrowing does not work when parent queue (qExt) does not also borrow. But it should according to man and PF FAQ.

Topic issue fix:
https://github.com/pfsense/pfsense/pull/4330

#6 Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review

#7 Updated by Renato Botelho about 1 month ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • Target version set to 2.5.0
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Also available in: Atom PDF