Project

General

Profile

Bug #3597

Todo #4224: PBIs are old skool. pkg-ng is the new shiny. We need to convert pfSense to use pkg-ng.

Package reinstall on system upgrades needs some fallback handling

Added by Doktor Notor over 5 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Category:
Package System
Target version:
Start date:
04/10/2014
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All

Description

Lost all packages on upgrade. No idea if the process was killed or what, does not exactly matter. Result:

- Installed packages list empty
- Diagnostics - Backup/Restore - Reinstall packages unavailable
- Digging through the system log and/or configuration backups to find out what was actually installed seriously sucks. In the end, all we end with is a flood of

php: rc.start_packages: $foo package is missing its configuration file and must be reinstalled.

in the system log.

Apparently the process is not tracked at all. Also, why is the list of packages that is created right before trying to reinstall the packages not saved somewhere and used for the reinstall all packages feature if the process completely/partially fails due to whatever reason?

History

#1 Updated by Chris Buechler over 5 years ago

  • Target version set to 2.2

Definitely some improvements to be made here.

One that'd go a long way is before doing anything, see if you can fetch something from https://packages.pfsense.org, and if not, bail without changing anything, leaving the pre-existing packages in place.

#2 Updated by Jim Thompson over 5 years ago

  • Assignee set to Renato Botelho

assigned to Renato.

on full installs, it might be nice to cache the packages.

#3 Updated by Jim Thompson over 5 years ago

need status if this is going to make 2.2 (if it's not in BETA, it's not going in)

#4 Updated by Renato Botelho over 5 years ago

Chris Buechler wrote:

Definitely some improvements to be made here.

One that'd go a long way is before doing anything, see if you can fetch something from https://packages.pfsense.org, and if not, bail without changing anything, leaving the pre-existing packages in place.

It works like this today, during the full reinstall process, if package list cannot be retrieved, it's aborted.

#5 Updated by Renato Botelho over 5 years ago

  • Target version changed from 2.2 to 2.3

Jim Thompson wrote:

need status if this is going to make 2.2 (if it's not in BETA, it's not going in)

This requires a big change and I don't think it's a good idea for 2.2.

There will be more changes in this area on 2.3, I'd say to hold this to be done together.

#6 Updated by Renato Botelho about 4 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
  • Parent task set to #4224

pfSense-upgrade fetches all updates before reboot, and finish the process during boot.

#7 Updated by Chris Buechler almost 4 years ago

  • Status changed from Feedback to Resolved

a variety of changes in 2.3 seem to have resolved all the package reinstall issues that weren't already fixed in earlier versions. The issue described in OP here is definitely fixed.

Also available in: Atom PDF