Diagnostics: Tables - Remove button dont work after update to PfSense 2.1.2
After updated to PfSense 2.1.2 the "IP Address" remove button dont work in "Diagnostics: Tables" for Firewall: Aliases
Fix Bug #3627 Diagnostics: Tables - Remove button dont work after update to PfSense 2.1.2
This annoyed me also, so I thought it worth finding what changes exactly broke this.
del_entry was broken on 2.1 branch by https://github.com/pfsense/pfsense/commit/fe3088b965a99772e76622d17ceae87288471edc
These 2 small changes make it work again without needing to reverse the other bits of stuff in that commit.
Note that Master does not have that commit at all. There are lots of these "XHTML Compliance" and similar commits in 2.1 branch that are not done in master. I don't understand why that is. Why don't those code cleanups also need to be applied to master?
#2 Updated by Jim Pingle over 5 years ago
- Category set to Web Interface
- Priority changed from Urgent to Normal
- Affected Version set to 2.1.2
- Affected Architecture set to All
It does appear to be broken on 2.1.2, but it does work on 2.2. We may want to fix it on 2.1.x if it's simple, but otherwise it's already working properly in 2.2 so it may not matter.
#3 Updated by Phillip Davis over 5 years ago
Pull request https://github.com/pfsense/pfsense/pull/1127
This annoyed me a bit also, so I chased down which lines of code exactly had broken it.
Note that there seems to also be a bigger issue, that there are lots of commits on 2.1-branch for various HTML/XHTML code cleanups that have never been applied to Master. Why is that? I will ask on dev list.