Project

General

Profile

Bug #3669

WAN IPs not being cached causing unnecessary "rc.start_packages: Restarting/Starting all packages"

Added by Nic Hannekum over 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
High
Assignee:
Ermal Luçi
Category:
Interfaces
Target version:
Start date:
05/20/2014
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.1.x
Affected Architecture:
All

Description

First bug report so please excuse administrative mistakes.

Affected version is actually 2.1.3 (maybe others)

There are actually two bugs, causing the /var/db/wan_cacheip and /var/db/wan_cacheipv6 files to not be generated.

The first is a typo in /etc/rc.newwanip:

[2.1.3-RELEASE][root@pfsense]/etc: diff rc.newwanip.pfsense rc.newwanip
191c191
<     if (is_ipaddr($curnwanip))
---
>     if (is_ipaddr($curwanip))

and the second is an invalid initial IPv6 IP address causing the is_ipaddrv6 function to return false:

[2.1.3-RELEASE][root@pfsense]/etc: diff rc.newwanipv6.pfsense rc.newwanipv6
114c114
< $oldipv6 = "";
---
> $oldipv6 = "::";

Note that the above IPv6 'fix' causes the following in /var/log/system.log:

May 20 22:21:20 pfsense php: rc.newwanipv6: The command '/sbin/ifconfig pppoe0 inet6 :: delete' returned exit code '1', the output was 'ifconfig: ioctl (SIOCDIFADDR): Can't assign requested address'

Associated revisions

Revision 38f6f50a (diff)
Added by Chris Buechler over 5 years ago

fix variable typo. ticket #3669

Revision a1b9ad59 (diff)
Added by Chris Buechler over 5 years ago

fix variable typo. ticket #3669

Revision 322cc018 (diff)
Added by Ermal Luçi over 4 years ago

Fixes #3669 Handle properly recording of the ipv6 interface new ip and do not issues commands that cannot succeed.

Revision 68716545 (diff)
Added by Ermal Luçi over 4 years ago

Fixes #3669 Handle properly recording of the ipv6 interface new ip and do not issues commands that cannot succeed.

History

#1 Updated by Chris Buechler over 5 years ago

  • Category changed from 62 to Interfaces
  • Priority changed from Normal to High
  • Target version set to 2.2

I fixed the typo in the variable part. Leaving this here for Ermal's review on the other.

#2 Updated by jeroen van breedam over 5 years ago

Would it be possible to set target version to 2.1.x ?
I've been struggling with the same thing (altough i thought it was a new feature) and had to set the gw monitoring to 3000ms to avoid a frequent restart of openvpn (i max out the upload speed of my vpn's a lot).

It would be nice to see a quick 2.1.4 release.
If that is impossible, a forum post with a link to an easy to implement patch by using the "system patches" package would also be a great help

kind regards.

#3 Updated by Renato Botelho over 5 years ago

You can always use gitsync to sync your installation with latest changes made on branch, in this case RELENG_2_1.

https://doc.pfsense.org/index.php/Updating_pfSense_code_between_snapshots

#4 Updated by Chris Buechler over 5 years ago

  • Status changed from New to Feedback
  • Target version changed from 2.2 to 2.1.4
  • Affected Version changed from 2.1-IPv6 to 2.1.x

#5 Updated by Chris Buechler about 5 years ago

  • Status changed from Feedback to Resolved

#6 Updated by David Burns over 4 years ago

Whilst this ticket has been marked resolved, the second part of the fix relating to /etc/rc.newwanipv6 has never been applied to 2.1 or 2.2.

The supplied fix to rc.newwanipv6 certainly seems to work ... but is there another issue identified by Ermal (or others) which has prevented the fix from being integrated?

Would be great if this fix could make it into 2.2.1

#7 Updated by Ermal Luçi over 4 years ago

  • Status changed from Resolved to New
  • Assignee set to Ermal Luçi
  • Target version changed from 2.1.4 to 2.2.1

Let me double check this issue again.

#8 Updated by Ermal Luçi over 4 years ago

  • Status changed from New to Feedback

Thank you for the persistence.
Merged a better/modified version of the fix suggested here.

#9 Updated by Ermal Luçi over 4 years ago

  • % Done changed from 0 to 100

#10 Updated by Ermal Luçi over 4 years ago

#11 Updated by Chris Buechler over 4 years ago

  • Status changed from Feedback to Resolved

last part fixed in 2.2.1, remainder fixed quite some time ago.

Also available in: Atom PDF