Bug #3900
closed
DynamicDNS should allow "@" at hostname
100%
Description
No-ip has the ability to update one of several IP addresses of a round-robin DNS A record. This is done adding a "@<label>" suffix at hostname. Eg.
myhost@mydomain.no-ip.com@label1 myhost@mydomain.no-ip.com@label2
However, trying to add such hostname in services_dyndns_edit.php results in the following error:
The following input errors were detected: The Hostname contains invalid characters.
Confirmed on pfSense 2.1.5
Updated by F. D.Castel about 10 years ago
BTW, where these configs are stored? Could I change them directly via Diagnostics / Edit File? It would be a good workaround, for now.
Updated by F. D.Castel about 10 years ago
Sent a pull request to fix this annoyance. ( https://github.com/pfsense/pfsense/pull/1315 )
Forum discussion at: https://forum.pfsense.org/index.php?topic=83163.0
Updated by Tiago Barrionuevo about 9 years ago
This won't be fixed?
There's a pull request / commit,
https://github.com/pfsense/pfsense/commit/6c163f6a881c96fc0cddb59cba6e13f5c619d3d8
but in pfSense 2.2.4 this is still not working.
Thanks in advance
Updated by Phillip Davis about 9 years ago
The pull request had issues with branches and merging and...
https://github.com/pfsense/pfsense/pull/1315
It seems that the 1-line change was never resubmitted cleanly and so it never got committed. If someone looked at the current code in the repo, made the needed change to it, and submitted a pull request then it would be looked at.
Updated by Kill Bill about 9 years ago
https://github.com/pfsense/pfsense/pull/1839
+ updated variant that just stops wasting time with unwanted sorts of hostname validations: https://github.com/pfsense/pfsense/pull/1914 (also backported as PR for the above 1839 RELENG_2_2 patch)
Updated by Renato Botelho almost 9 years ago
- Status changed from New to Feedback
- Assignee set to Renato Botelho
- Target version set to 2.3
- % Done changed from 0 to 100
Pull request has been merged, thanks!
Updated by Chris Buechler almost 9 years ago
- Status changed from Feedback to Resolved
- Affected Version changed from 2.1.x to All