Project

General

Profile

Actions

Bug #3970

closed

some files not removed on upgrade to 2.2

Added by Chris Buechler almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Category:
Upgrade
Target version:
Start date:
10/31/2014
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.2
Affected Architecture:

Description

There is at least one file from earlier versions that has to be removed in the process of upgrading to 2.2, with setkey moving from /usr/local/sbin/ to /sbin/. Could be others, need to check.


Files

3970.diff (20.1 KB) 3970.diff Renato Botelho, 11/03/2014 01:32 PM
extra-files-post-upgrade-101-22.txt (184 KB) extra-files-post-upgrade-101-22.txt Chris Buechler, 11/08/2014 10:09 PM
22-upgrade-file-comparison.txt (90.4 KB) 22-upgrade-file-comparison.txt Chris Buechler, 11/10/2014 12:27 PM
20141111-upgrade-file-comparison.txt (90.4 KB) 20141111-upgrade-file-comparison.txt Chris Buechler, 11/11/2014 11:51 AM
20141112-22-upgrade-file-diff.txt (239 KB) 20141112-22-upgrade-file-diff.txt Chris Buechler, 11/12/2014 12:03 AM
20141112-1307-upgrade-file-diff.txt (200 KB) 20141112-1307-upgrade-file-diff.txt Chris Buechler, 11/12/2014 01:03 PM
22-upg-file-comp3.txt (34.5 KB) 22-upg-file-comp3.txt Chris Buechler, 11/13/2014 10:24 PM
Actions #1

Updated by Renato Botelho almost 10 years ago

  • File 3970.diff 3970.diff added
  • Status changed from New to Confirmed
  • Assignee set to Renato Botelho

/tmp/post_upgrade_command.php is executed after new files are in place and before reboot, probably the root cause is new php binary cannot be executed on old system, then it toss some errors:

1: Invalid argument
1: Invalid argument

I'm going to dig into it and find a solution

Actions #2

Updated by Chris Buechler almost 10 years ago

  • % Done changed from 0 to 50

Renato found solution today, implementing tomorrow morning.

Actions #3

Updated by Renato Botelho almost 10 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 50 to 100

Please try new snapshots, after move part of the logic to shell script it passed on all my tests

Actions #4

Updated by Chris Buechler almost 10 years ago

  • Assignee changed from Renato Botelho to Chris Buechler
Actions #5

Updated by Chris Buechler almost 10 years ago

confirmed that works now. Need to do more testing to ensure the obsoletedfiles list is complete.

Actions #6

Updated by Chris Buechler almost 10 years ago

I did a clean install of 1.0.1-REL, then upgraded that to 1.2, 1.2.1, 1.2.2, 1.2.3, 2.0, 2.0.1, 2.0.2, 2.0.3, 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.2. Every stable release from 1.0.1 on.

Ended up with upwards of 2000 more files on the system upgraded from 1.0.1 to 2.2 than a clean install of the same 2.2 snapshot. List attached.

Removal works fine now, the list is just significantly incomplete if you go way back.

Actions #7

Updated by Renato Botelho almost 10 years ago

  • Status changed from Confirmed to Assigned
  • Assignee set to Renato Botelho

I was working on a similar list but only for a 2.1.5 fresh install against 2.2. Your test is better and I'll check this file list and add necessary files to pfSense.obsoletedfiles.

Actions #8

Updated by Chris Buechler almost 10 years ago

I noticed that list takes only files currently, some of those would be easier to just rm -rf a directory instead of a slew of files in it (like old /usr/lib/ PHP stuff, /etc/inc/m0n0, etc. that no longer exist). Maybe if the obsoletedfiles entry ends in / then it does rm -rf instead.

The directory where the files exist is the Q:\ path shown. I ran that diff with Winmerge, where Q:\ was scp mounted to / on the upgraded system. The filename that's under that path is the first column.

Actions #9

Updated by Chris Buechler almost 10 years ago

updated comparison attached. S:\ is the upgraded system.

Actions #10

Updated by Renato Botelho almost 10 years ago

Chris, can you compare files again but now use a fresh installed 2.2? I fixed a bug in bsdinstaller that was introducing a lot of gettext files in 2.2. new images have less files.

Actions #11

Updated by Chris Buechler almost 10 years ago

updated comparison, but against a not freshly installed 2.2 so this is probably not useful at all. When the next new snapshot comes out, I'll update it against a new clean 2.2 install.

Actions #12

Updated by Chris Buechler almost 10 years ago

  • Assignee changed from Renato Botelho to Chris Buechler

to me for testing against next snapshot

Actions #13

Updated by Chris Buechler almost 10 years ago

updated diff attached.

V: is the clean install, Q: the upgraded system.

Actions #14

Updated by Chris Buechler almost 10 years ago

  • % Done changed from 100 to 90
Actions #15

Updated by Renato Botelho almost 10 years ago

Something is wrong, fresh install is not supposed to have those gettext files. I got last i386 and amd64 iso files and checked, gettext files are not present.

Actions #16

Updated by Chris Buechler almost 10 years ago

last one was messed up by WebDrive's caching. attached an update

Actions #17

Updated by Renato Botelho almost 10 years ago

  • Assignee changed from Renato Botelho to Chris Buechler

Pass it to Chris to run a final test before commit.

Actions #18

Updated by Chris Buechler almost 10 years ago

Looks much better, fine to go ahead and commit that.

Still missing some, see attached.

Actions #19

Updated by Chris Buechler almost 10 years ago

  • Assignee changed from Chris Buechler to Renato Botelho
Actions #20

Updated by Chris Buechler almost 10 years ago

also remember to add the obsolete openntpd files JimP mentioned.

Actions #21

Updated by Renato Botelho almost 10 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 90 to 100
Actions #22

Updated by Chris Buechler almost 10 years ago

  • Status changed from Feedback to Resolved

I added the last few missing ones, this is good now.

Actions

Also available in: Atom PDF