pfSense

/tmp/post_upgrade_command.php is executed after new files are in place and before reboot, probably the root cause is new php binary cannot be executed on old system, then it toss some errors:

1: Invalid argument
1: Invalid argument

I'm going to dig into it and find a solution

Renato found solution today, implementing tomorrow morning.

Please try new snapshots, after move part of the logic to shell script it passed on all my tests

I did a clean install of 1.0.1-REL, then upgraded that to 1.2, 1.2.1, 1.2.2, 1.2.3, 2.0, 2.0.1, 2.0.2, 2.0.3, 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.2. Every stable release from 1.0.1 on.

Ended up with upwards of 2000 more files on the system upgraded from 1.0.1 to 2.2 than a clean install of the same 2.2 snapshot. List attached.

Removal works fine now, the list is just significantly incomplete if you go way back.

I was working on a similar list but only for a 2.1.5 fresh install against 2.2. Your test is better and I'll check this file list and add necessary files to pfSense.obsoletedfiles.

updated comparison attached. S:\ is the upgraded system.

updated comparison, but against a not freshly installed 2.2 so this is probably not useful at all. When the next new snapshot comes out, I'll update it against a new clean 2.2 install.

to me for testing against next snapshot

updated diff attached.

V: is the clean install, Q: the upgraded system.

last one was messed up by WebDrive's caching. attached an update

Pass it to Chris to run a final test before commit.

Looks much better, fine to go ahead and commit that.

Still missing some, see attached.

Applied in changeset 9612943eaa3c6ef427ea4414f7c32dc2b326dd55.

I added the last few missing ones, this is good now.