Project

General

Profile

Actions

Bug #4180

closed

OpenVPN Backend for authentication field does not process in other languages

Added by Phillip Davis about 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
OpenVPN
Target version:
Start date:
01/05/2015
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.2
Affected Architecture:

Description

Forum: https://forum.pfsense.org/index.php?topic=86326.0
The code is using the text of the translated name to try and match what is selected already "Local Database" etc. And is also then trying to put the translated text back in the config as the value.
It should be using the translated text for display only, and the fixed key "Local Database"... is what is stored in the config...

Actions #2

Updated by Renato Botelho about 7 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Merged, thanks!

Actions #3

Updated by Chris Buechler about 7 years ago

  • Status changed from Feedback to Resolved

I can't easily test this, but the change looks good to me and Renato, and I trust Phil to get it right. If there are issues Phil, can re-open and/or add to this as needed.

Actions #4

Updated by Phillip Davis about 7 years ago

I tested by have an OpenVPN server setup in English, then switch language to Turkish. The words for "Local Database" change to the Turkish. Press Save and confirm it saves without error, check in config.xml that the XML has the string "Local Database" in there still.
Add an OpenVPN server in Turkish - again confirm that the XML has the string "Local Database" in there.
Switch back to English, view the 2 servers and see that "LOcal Database" is displayed. Press save and again confirm that the XML has the string "Local Database" in there.
That confirms that all the change is to the GUI front-end display, and that the back-end will continue to always see the "key" values, that happen to be English strings.

Actions

Also available in: Atom PDF