pfSense » pfSense Packages

This also happens on system boot.

I dug a little deeper and here is what I discovered.

By the time "radiusd.sh start" is invoked second time, first instance of "radiusd.sh start" has finished executing, but radiusd is not running yet. What is actually running is process "/usr/pbi/.pbirun /usr/local/sbin/radiusd". Function _find_processes() in /etc/rc.subr does not check for this (it only looks for radiusd in the process name which would be /usr/pbi/.pbirun) and thus does not stop script execution and print "radiusd already running? (pid=xxx).".

I have modified radiusd.sh to prevent it from being executed in parallel and to wait a bit for the process to start before releasing the lock. It appears to be working great on v2.2. Devs, if you are ok with this solution I can test it with v2.1 and create a proper patch.

#!/bin/sh
# This file was automatically generated
# by the pfSense service handler.

rc_start() {
    SERVICENAME="radiusd" 
    LOCKFILE="/tmp/${SERVICENAME}_start.lock" 
    PIDFILE="/var/run/${SERVICENAME}.pid" 

    # prevent this part of script from running in parallel 
    if ( set -o noclobber; echo "$$" > "$LOCKFILE") 2> /dev/null; then
        # make sure lock file is removed even if script is terminated 
        trap 'rm -f "$LOCKFILE"; exit $?' INT TERM EXIT

        /usr/pbi/freeradius-amd64/local/etc/rc.d/radiusd onestart

        # try to wait until the service starts 
        if [ ! -f "$PIDFILE" ]; then
            echo "$SERVICENAME.sh: PID file was not found" 

            for i in 1 2 3 4 5; do
                if [ -f "$PIDFILE" ]; then
                    echo "$SERVICENAME.sh: Service started PID: `cat $PIDFILE`" 
                    break
                else
                    echo "$SERVICENAME.sh: Waiting 0.5 seconds" 
                    sleep 0.5 
                fi
            done
        else
            echo "$SERVICENAME.sh: Service running PID: `cat $PIDFILE`" 
        fi

        rm -f "$LOCKFILE" 
        trap - INT TERM EXIT
    else
        echo "$SERVICENAME.sh: Cannot continue at this moment, this script is already trying to start service PID: $(cat $LOCKFILE)" 
    fi
}

rc_stop() {
    /usr/pbi/freeradius-amd64/local/etc/rc.d/radiusd onestop
}

case $1 in
    start)
        rc_start
        ;;
    stop)
        rc_stop
        ;;
    restart)
        rc_stop
        rc_start
        ;;
esac

Pull request: https://github.com/pfsense/pfsense-packages/pull/839

Tested, changes are working as expected.

Strangely for the change to show up package must be removed/installed rather than reinstalled. Even though output when reinstalling says "Executing custom_php_install_command()...done.".