Project

General

Profile

Actions

Bug #4410

closed

pfBlockerNG adding commented IPs

Added by Ryan . almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
pfBlockerNG
Target version:
-
Start date:
02/11/2015
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Affected Version:
Affected Plus Version:
Affected Architecture:

Description

We have a list provider that requires our IP be passed as a variable in the query (e.g. http://example.com/list.php?ip=x.x.x.x). There is a reason for it, but the details of that are unimportant. What is important is that the outputted list has a comment at the top that contains the IP we passed in (e.g. # This is a list for x.x.x.x). It appears that pfBlockerNG is reading that line and adding the IP address to the block list. If I look in /var/db/pfblockerng/original/ at the orig file, it shows the IP in the commented line and nowhere else. However, if I look in /var/db/pfblockerng/deny at the txt file, it shows the IP address in the list itself.

I was able to work around this by adding the IP to a whitelist. Shouldn't comments be ignore when parsing the IPs?

pfSense - 2.2-RELEASE
pfBlockerNG - 1.03

Actions #1

Updated by Chris Buechler almost 11 years ago

  • Category set to pfBlockerNG
Actions #2

Updated by BBcan177 . almost 11 years ago

@Ryan. Thanks for the Bug report. I haven't seen a Comment line with an IP in it before. The fix for this bug is in my Pull Request #818 (Version 1.04)

Actions #3

Updated by Ryan . almost 11 years ago

Great! I'll try it out once it's released.

Thanks

Actions #4

Updated by BBcan177 . almost 11 years ago

Hi Ryan, my PR for pfBNG v1.04 was merged. Please let me know if that fixes your issue.
There is a "pfBlockerNG" thread in the pfSense Forum "Packages" category also.

Actions #5

Updated by Ryan . almost 11 years ago

This is now working and the ticket can be closed. Thanks BBcan177 for the fix. Sorry it took so long to get back with status (we're in a busy period at work).

Actions #6

Updated by Chris Buechler almost 11 years ago

  • Status changed from New to Resolved

thanks for the follow up.

Actions

Also available in: Atom PDF