Project

General

Profile

Bug #4435

Invalid increment in DHCP6 server address range check

Added by Daniel Becker over 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Category:
DHCP (IPv6)
Target version:
Start date:
02/16/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.2
Affected Architecture:
All

Description

When computing the start IP for the 'available range' field, services_dhcpv6.php attempts to increment a colon-formatted v6 address:

$range_from = gen_subnetv6($ifcfgip, $ifcfgsn);
$range_from++;

Since increment on a non-numeric value fails, range_from retains the un-incremented value.

History

#1 Updated by Daniel Becker over 5 years ago

Note that this is actually matches the behavior of the range checks that services_dhcpv6.php performs: The actual check uses the range from gen_subnetv6() to gen_subnetv6_max(), which does include the first (= all-zeroes host part) v6 address in the prefix.

#3 Updated by Chris Buechler over 5 years ago

  • Assignee set to Chris Buechler
  • Target version set to 2.2.1

#4 Updated by Daniel Becker over 5 years ago

Are there any issues with my pull request that would prevent it from being accepted?

#5 Updated by Renato Botelho over 5 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Merged

#6 Updated by Chris Buechler about 5 years ago

  • Status changed from Feedback to Resolved

fixed. Thanks Daniel for the contributions!

Also available in: Atom PDF