Bug #4435
closed
Invalid increment in DHCP6 server address range check
100%
Description
When computing the start IP for the 'available range' field, services_dhcpv6.php attempts to increment a colon-formatted v6 address:
$range_from = gen_subnetv6($ifcfgip, $ifcfgsn);
$range_from++;
Since increment on a non-numeric value fails, range_from retains the un-incremented value.
Updated by Daniel Becker almost 10 years ago
Note that this is actually matches the behavior of the range checks that services_dhcpv6.php performs: The actual check uses the range from gen_subnetv6() to gen_subnetv6_max(), which does include the first (= all-zeroes host part) v6 address in the prefix.
Updated by Daniel Becker almost 10 years ago
Pull request for fix here: https://github.com/pfsense/pfsense/pull/1478
Updated by Chris Buechler almost 10 years ago
- Assignee set to Chris Buechler
- Target version set to 2.2.1
Updated by Daniel Becker over 9 years ago
Are there any issues with my pull request that would prevent it from being accepted?
Updated by Renato Botelho over 9 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Merged
Updated by Chris Buechler over 9 years ago
- Status changed from Feedback to Resolved
fixed. Thanks Daniel for the contributions!