Project

General

Profile

Bug #4443

diag_arp does not display reverse resolved hostnames containing underscore

Added by Phillip Davis over 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Diagnostics
Target version:
Start date:
02/18/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

is_hostname() and is_domain() allow underscore in the names. So it is possible to have underscore in host names, for example in DHCP server static mapped entries I have some things like:
10.42.3.4 client-pc-01_LAN
10.42.3.5 client-pc-01_WIFI
These reverse-resolve fine - 10.42.3.4 becomes client-pc-01_LAN
But the preg_match in diag_arp.php misses such names that have an underscore in them.
I noticed this when looking into forum post: https://forum.pfsense.org/index.php?topic=88956.0

Pull request: https://github.com/pfsense/pfsense/pull/1497

Associated revisions

Revision 934c88ee (diff)
Added by Renato Botelho about 5 years ago

Proper fix #4443, do not unset carp entry when content differ, also set correct real interface and use subnet to check IP protocol

Revision 214c8102 (diff)
Added by Renato Botelho about 5 years ago

Proper fix #4443, do not unset carp entry when content differ, also set correct real interface and use subnet to check IP protocol

History

#1 Updated by Renato Botelho about 5 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Phillip Davis about 5 years ago

It seems Renato has accidentally referenced this issue in applying some CARP thing.

#4 Updated by Phillip Davis about 5 years ago

tHIS BUG (diag_arp display reverse resolved hostnames containing underscore) has been fixed by commit to master:
https://github.com/pfsense/pfsense/commit/6777fc3b6efb59bf42ee709508cf384ec5890dcf

and to RELENG_2_2:
https://github.com/pfsense/pfsense/commit/4f5967b9a893447b936c06858183a2277ac5bb57

#5 Updated by Chris Buechler about 5 years ago

  • Status changed from Feedback to Resolved
  • Target version set to 2.2.1

yeah that was #4446 that Renato's commit meant to reference.

Thanks for noting this as resolved, Phil.

Also available in: Atom PDF