Bug #4443
closed
diag_arp does not display reverse resolved hostnames containing underscore
100%
Description
is_hostname() and is_domain() allow underscore in the names. So it is possible to have underscore in host names, for example in DHCP server static mapped entries I have some things like:
10.42.3.4 client-pc-01_LAN
10.42.3.5 client-pc-01_WIFI
These reverse-resolve fine - 10.42.3.4 becomes client-pc-01_LAN
But the preg_match in diag_arp.php misses such names that have an underscore in them.
I noticed this when looking into forum post: https://forum.pfsense.org/index.php?topic=88956.0
Pull request: https://github.com/pfsense/pfsense/pull/1497
Updated by Renato Botelho almost 10 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset 934c88ee9535919b8b75b6e939b2a6becb9561bd.
Updated by Renato Botelho almost 10 years ago
Applied in changeset 214c81026b6b13dc750ac971afce975117b6c493.
Updated by Phillip Davis almost 10 years ago
It seems Renato has accidentally referenced this issue in applying some CARP thing.
Updated by Phillip Davis almost 10 years ago
tHIS BUG (diag_arp display reverse resolved hostnames containing underscore) has been fixed by commit to master:
https://github.com/pfsense/pfsense/commit/6777fc3b6efb59bf42ee709508cf384ec5890dcf
and to RELENG_2_2:
https://github.com/pfsense/pfsense/commit/4f5967b9a893447b936c06858183a2277ac5bb57
Updated by Chris Buechler almost 10 years ago
- Status changed from Feedback to Resolved
- Target version set to 2.2.1
yeah that was #4446 that Renato's commit meant to reference.
Thanks for noting this as resolved, Phil.