Project

General

Profile

Bug #455

On initial wizard reload button do not put browser on new assigned ip.

Added by Oscar Francia over 9 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
Web Interface
Target version:
-
Start date:
03/27/2010
Due date:
% Done:

30%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

On initial wizard reload button do not put browser on new ip.

Associated revisions

Revision fd7f136b (diff)
Added by Erik Fonnesbeck over 8 years ago

Redirect to the correct IP at the end of the setup wizard if accessing it on an IP address that was changed. Fixes #455

Revision 6898927f (diff)
Added by Erik Fonnesbeck over 8 years ago

Make this check more general in case someone makes a wizard that changes an opt interface's IP address and wants to use the "Reload in progress" step. Ticket #455

Revision 0bee2010 (diff)
Added by Erik Fonnesbeck over 8 years ago

Save the host name and domain to a temporary location until the setup wizard is finished to prevent triggering the DNS rebind message. Fixes #1022 Also use this information to implement the redirect for changed host for ticket #455

History

#1 Updated by Erik Fonnesbeck over 9 years ago

When I was looking at the code when trying to fix the issue with showing the IP address twice in the image link at the end, I thought this might possibly be the case, but I didn't change it because I wasn't sure. I didn't test it at that time because I didn't want to interrupt my connection. Looks like I was right about it, though.

#2 Updated by Ermal Luçi about 9 years ago

This will not be possible because the new ip is not yet setup in the interface and it need to be added special code to find the correct ip address.
Not sure it is needed.

#3 Updated by Chris Buechler about 9 years ago

after hitting reload at the last page in the wizard in 1.2.3, it redirects to the changed IP if you're accessing it using the LAN IP. It should still do that.

#4 Updated by Erik Fonnesbeck about 9 years ago

Somehow it needs to figure out which interface it was accessed on to redirect to the correct address from the configuration. If the old address no longer exists in the configuration, it may need to find it some other way.

#5 Updated by Erik Fonnesbeck over 8 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#6 Updated by Ermal Luçi over 8 years ago

  • % Done changed from 100 to 30

The fix is not complete.
Please do it right....

#7 Updated by Erik Fonnesbeck over 8 years ago

Is this last change something like what you meant?

By the way, this could also be designed to check whether the user changed the host name but is currently accessing by the old host name, though I'm not quite sure how I might go about finding what the old host name was, accurately without false positives. Might be unnecessary because of DNS caching, though.

#8 Updated by Erik Fonnesbeck over 8 years ago

Except for that I just realized that the DNS rebind check wouldn't allow the old host name by default. This needs a new ticket of its own.

#9 Updated by rancor rancor about 8 years ago

What is the needed feedback? I want to test fixes but there does not seems to be neither a fix nor a question

// rancor

#10 Updated by Chris Buechler almost 8 years ago

  • Status changed from Feedback to Closed
  • Target version deleted (2.0)

Also available in: Atom PDF