Project

General

Profile

Bug #4884

Pkg install additional files can fail but instllation does not abort

Added by Phillip Davis over 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Package System
Target version:
Start date:
07/26/2015
Due date:
% Done:

0%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

The code that gets "additional files" during package install does not pass failure codes back up to the overall package install routines. So if there is an error getting one of the additional files it is reported in the text progress display but the installer code thinks the install succeeded. You have to watch the text output carefully and then go back and delete the package and try again if "additional files" went wrong.

I think this has been an issue for a while, maybe on 2.2.*? But it now happens more for me, I suspect because of the lower general timeout for making connections.

Sample output from today at a site that has crud internet (usually has packet loss):

Beginning package installation for AutoConfigBackup .
Downloading package configuration file... done.
Saving updated package information... done.
Downloading AutoConfigBackup and its dependencies...
Loading package configuration... done.
Configuring package components...
Loading package configuration... done.
Additional files... crypt_acb.php failed.
Loading package instructions...
Custom commands...
Executing custom_php_resync_config_command()...done.
Menu items... done.
Integrated Tab items... done.
Writing configuration... done.

Installation completed. Please check to make sure that the package is configured from the respective menu then start the package.

History

#1 Updated by Phillip Davis over 4 years ago

Pull request for RELENG_2_2 https://github.com/pfsense/pfsense/pull/1790

I managed to get an example with it failing more gracefully after fixing the "additional files" error handling. Here is the text output:

Beginning package installation for AutoConfigBackup .
Downloading package configuration file... done.
Saving updated package information... done.
Downloading AutoConfigBackup and its dependencies...
Loading package configuration... done.
Configuring package components...
Loading package configuration... done.
Additional files... parse_config_upload.php failed.
Removing package...
Removing AutoConfigBackup components...
Tabs items... done.
Menu items... done.
Loading package instructions...
Removing package instructions...done.
Auxiliary files... done.
Package XML... done.
Configuration... done.
done.
Failed to install package.

This correctly did its best to get rid of partly-installed stuff, gave the "Failed to install package" message, and left the system saying the package is not installed - all ready for the user to try again.

#2 Updated by Chris Buechler about 4 years ago

  • Status changed from New to Confirmed
  • Affected Version changed from 2.2.x to All

#3 Updated by Renato Botelho about 4 years ago

  • Status changed from Confirmed to Feedback
  • Target version set to 2.2.5

Pull request has been merged. Thanks!

#4 Updated by Chris Buechler about 4 years ago

  • Status changed from Feedback to Resolved

this works for 2.2.5. In 2.3, there aren't any individual files to fetch so that's a non-issue.

Thanks Phil!

Also available in: Atom PDF