Bug #5092
closed
firewall_virtual_ip.php - Remove "CARP Settings" link/tab
100%
Description
The HA Settings moved to System > High Avail. Sync several versions ago now, probably safe to nuke the "CARP Settings" legacy shortcut on firewall_virtual_ip.php since it doesn't belong there.
IIRC the intent was to only keep it around for one major version past the change. Removing that means the whole "tab" control could be removed from the page, which would clean it up more.
If it's desirable to keep it should at least be renamed "High Availability Settings".
Updated by Chris Buechler about 6 years ago
yeah the intention there was to keep the existing tab since it's referenced in so many places all over the Internet. Its name was kept as is for the same reason, to match a slew of list, forum, and old documentation references.
It's been long enough that it's fine to remove.
Updated by Steve Beaver about 6 years ago
- Status changed from Confirmed to Feedback
- Assignee changed from Steve Beaver to Jim Pingle
Tab zapped as requested
Updated by Steve Beaver about 6 years ago
- % Done changed from 0 to 100
Applied in changeset pfsense:59837fb151b188e525d453a0b2a5b81ed7331221.
Updated by Jim Pingle about 6 years ago
- Status changed from Feedback to Confirmed
- Assignee changed from Jim Pingle to Steve Beaver
The "CARP Settings" tab is gone now it just has one "tab" -- "Virtual IPs". Seems odd to just have one tab. Can that be zapped also?
Updated by Steve Beaver about 6 years ago
- Status changed from Confirmed to Feedback
- Assignee changed from Steve Beaver to Chris Buechler
Updated by Steve Beaver about 6 years ago
Applied in changeset pfsense:1ed8d35ba375d187c2f8cbda16341fd2a74e949e.
Updated by Jim Pingle about 6 years ago
- Status changed from Feedback to Resolved
Looks much cleaner now, thanks!