Project

General

Profile

Actions
Copy link

Bug #5092

closed
JP CB

firewall_virtual_ip.php - Remove "CARP Settings" link/tab

Bug #5092: firewall_virtual_ip.php - Remove "CARP Settings" link/tab

Added by Jim Pingle about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Chris Buechler
Target version:
pfSense - 2.3
Start date:
09/03/2015
Due date:
% Done:

100%

Estimated time:

Description

The HA Settings moved to System > High Avail. Sync several versions ago now, probably safe to nuke the "CARP Settings" legacy shortcut on firewall_virtual_ip.php since it doesn't belong there.

IIRC the intent was to only keep it around for one major version past the change. Removing that means the whole "tab" control could be removed from the page, which would clean it up more.

If it's desirable to keep it should at least be renamed "High Availability Settings".

CB Updated by Chris Buechler about 11 years ago Actions
Copy link
 #1

yeah the intention there was to keep the existing tab since it's referenced in so many places all over the Internet. Its name was kept as is for the same reason, to match a slew of list, forum, and old documentation references.

It's been long enough that it's fine to remove.

Updated by Anonymous about 11 years ago Actions
Copy link
 #2

  • Status changed from Confirmed to Feedback
  • Assignee changed from Anonymous to Jim Pingle

Tab zapped as requested

Updated by Anonymous about 11 years ago Actions
Copy link
 #3

  • % Done changed from 0 to 100

Applied in changeset pfsense:commit:59837fb151b188e525d453a0b2a5b81ed7331221.

JP Updated by Jim Pingle about 11 years ago Actions
Copy link
 #4

  • Status changed from Feedback to Confirmed
  • Assignee changed from Jim Pingle to Anonymous

The "CARP Settings" tab is gone now it just has one "tab" -- "Virtual IPs". Seems odd to just have one tab. Can that be zapped also?

Updated by Anonymous about 11 years ago Actions
Copy link
 #5

Removed as requested

Updated by Anonymous about 11 years ago Actions
Copy link
 #6

  • Status changed from Confirmed to Feedback
  • Assignee changed from Anonymous to Chris Buechler

Updated by Anonymous about 11 years ago Actions
Copy link
 #7

Applied in changeset pfsense:commit:1ed8d35ba375d187c2f8cbda16341fd2a74e949e.

JP Updated by Jim Pingle about 11 years ago Actions
Copy link
 #8

  • Status changed from Feedback to Resolved

Looks much cleaner now, thanks!

Actions
Copy link

Also available in: Atom