pfSense » Bootstrap

Antenna controls now default to "Default"

Applied in changeset pfsense:c71c434b63dfa2bb628cb7dce769d361d385a9b6.

On a fully up-to-date system with a wireless card, it's still defaulting to Auto for me.

If $pconfig['txantenna'] is not set, the selector value is null, and the null array element is 'Default'.

Would you check your config file please and see what valueis in there for rxantenna and txantenna? Blank, '0' or '1' ?

Thanks

Code:

if (isset($wl_sysctl["{$wl_sysctl_prefix}.txantenna"])) {
            $group->add(new Form_Select(
                'txantenna',
                null,
                (isset($pconfig['txantenna'])) ? $pconfig['txantenna']:'',
                ['' => 'Default', '0' => 'Auto', '1' => '#1', '2' => '#2']
            ))->setHelp('Transmit antenna');

Before adding the interface it did not exist in config.xml at all and there was nothing in in the wireless tag.

Assigning the interface, it appears like so:

                <opt2>
                        <descr><![CDATA[OPT2]]></descr>
                        <if>ath0</if>
                        <wireless/>
                </opt2>

And farther down in the config:

 <wireless/>

Navigating to Interfaces > OPT2 it shows Auto for antennas.

Inspecting the source shows both options marked selected:

<select id="txantenna" class="form-control" name="txantenna">
    <option selected="" value="">Default</option>
    <option selected="" value="0">Auto</option>
    <option value="1">#1</option>
    <option value="2">#2</option>
</select>

Thanks for your help in finding this!

It was an obscure issue in the Select.class.php framework file wherein '' == '0' if one is a string and the other an int.

It defaults to "default" now, but when manually set to auto, it still marks default as selected. I know PHP is pretty quirky when it comes to use of empty() on "" vs 0, 0 even as a string all evaluate to true. Might be related.

Fixed and removed.

The Antenna selection options are still showing up here for me when synced to master.

Mia culpa

if(ANTENNAS) condition corrected

Applied in changeset pfsense:725f987f52d6d770d4d4ee522fa71eeb5790b13c.

Gone now. Thanks!

Hello, what about 3 antenna port pcie cards? I learned the AR5BXB112 functions in some appliances. Is the 3rd port not utilized in this situation?

ref:
Regression #14703