Project

General

Profile

Bug #5162

Renaming an alias to an existing name is not prevented by input validation

Added by Jim Pingle over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Rules / NAT
Target version:
2.2.5
Start date:
09/18/2015
Due date:
% Done:

50%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

If you create two aliases and rename the second one to the same name as the first, it is allowed by the GUI but obviously undesirable. Creating a new alias with the same name as an existing alias is prevented as expected.

Bug is present on 2.1.x, 2.2.x and still on 2.3.

History

#1 Updated by Jim Pingle over 4 years ago

  • Status changed from New to Confirmed

#3 Updated by Renato Botelho over 4 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

Pull requests have been merged. Thanks!

#4 Updated by Jim Pingle over 4 years ago

  • Status changed from Feedback to Confirmed

The problem is still present on master (2.3), but appears to be fixed on 2.2.x.

#5 Updated by Jim Pingle over 4 years ago

  • % Done changed from 100 to 50

#6 Updated by Phillip Davis over 4 years ago

I don't have a system setup with 2.3 just yet. I looked at the processing and the new bootstrap code still seems to pass across 'id' like before, and:
$a_aliases = &$config['aliases']['alias'];
looks to have the same structure as previously.
So I expect that the same validation loop from 2.2.* will work in 2.3
Hmmm - what is the trick?

#7 Updated by Jim Pingle over 4 years ago

  • Status changed from Confirmed to Resolved

I synchronized my VM again and now it worked. Somehow it must not have picked up this change the first try.

Also available in: Atom PDF