Bug #5342
Cannot change outbound NAT modes when using non-English translation
100%
Description
Forum: https://forum.pfsense.org/index.php?topic=101276.0
"Save" is not being translated when checking the $_POST value and so is not matching.
Seems to be a bug since 2006 (forever - never worked since translations existed) https://github.com/pfsense/pfsense/commit/82d0dfc4609f27e691e29e8a379fe8f43beff328
Associated revisions
History
#1
Updated by Phillip Davis about 5 years ago
Updated by Pull request for RELENG_2_2: https://github.com/pfsense/pfsense/pull/1984
Pull request for master: https://github.com/pfsense/pfsense/pull/1985
#2
Updated by Phillip Davis about 5 years ago
Note: PR for master currently breaks the behavior in master, because there are other issues with the (non) translation of UI buttons.
#3
Updated by Jim Thompson about 5 years ago
Updated by - Assignee changed from Phillip Davis to Steve Beaver
#4
Updated by Steve Beaver about 5 years ago
Updated by - Status changed from New to Feedback
- Assignee changed from Steve Beaver to Phillip Davis
I see no need to test the value of the $_POST['save'] parameter so have removed the test.
There were a couple of other issues with the page that have also been corrected.
The action buttons have been changed to icons. There was not enough space in the display to sensibly use icons.
#5
Updated by Steve Beaver about 5 years ago
- % Done changed from 0 to 100
Applied in changeset 11a6f29cde1331c5e31204d3794c6f4f9a32aa57.
#6
Updated by Phillip Davis about 5 years ago
2.3-ALPHA (amd64)
built on Mon Oct 26 19:32:58 CDT 2015
FreeBSD 10.2-STABLE
Works
#7
Updated by Phillip Davis about 5 years ago
2.2.5-DEVELOPMENT (i386)
built on Mon Oct 26 18:12:44 CDT 2015
FreeBSD 10.1-RELEASE-p23
Works
#8
Updated by Chris Buechler about 5 years ago
Updated by - Status changed from Feedback to Resolved
also confirmed on 2.2.5. thanks Phil!
Fixed #5342