Project

General

Profile

Actions

Bug #5343

closed

Cannot upload or download from exec.php when in non-English language

Added by Phillip Davis almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
10/25/2015
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

e.g. set language to Turkish (which has "Download" and "Upload" translations).
Diagnostics->Command Prompt
Try to download or upload a file.
It does not work - nothing happens when the download or upload button is pushed.

Actions #1

Updated by Phillip Davis almost 6 years ago

Actions #2

Updated by Phillip Davis almost 6 years ago

Pull request for master: https://github.com/pfsense/pfsense/pull/1987

The fix is actually needed in master as well as RELENG_2_2 because the code in master is still using some non-bootstrap for this, so it needs to work just as in RELENG_2_2.

Actions #3

Updated by Steve Beaver almost 6 years ago

Thanks Phil. I will address this later today. I agree that passing language dependent terms in a POST request is bad. I propose that we separate the display from the value and use one word, capitalized English terms for the latter. e.g.:

<button class="btn btn-sm btn-success" value="SAVE">></button>

or similar depending on the HTML

Actions #4

Updated by Jim Thompson almost 6 years ago

  • Assignee changed from Phillip Davis to Steve Beaver
Actions #5

Updated by Steve Beaver almost 6 years ago

  • Status changed from New to Feedback
  • Assignee changed from Steve Beaver to Phillip Davis

Updated as suggested above.
Also added Javascript to scroll the page to the PHP section when a PHP command is executed.

Actions #6

Updated by Steve Beaver almost 6 years ago

  • % Done changed from 0 to 100
Actions #7

Updated by Phillip Davis almost 6 years ago

2.3-ALPHA (amd64)
built on Mon Oct 26 19:32:58 CDT 2015
FreeBSD 10.2-STABLE

Works

Actions #8

Updated by Phillip Davis almost 6 years ago

2.2.5-DEVELOPMENT (i386)
built on Mon Oct 26 18:12:44 CDT 2015
FreeBSD 10.1-RELEASE-p23

Works

Actions #9

Updated by Chris Buechler almost 6 years ago

  • Status changed from Feedback to Resolved

fixed

Actions

Also available in: Atom PDF