Bug #5343
closed
Cannot upload or download from exec.php when in non-English language
Added by Phillip Davis almost 9 years ago.
Updated almost 9 years ago.
Description
e.g. set language to Turkish (which has "Download" and "Upload" translations).
Diagnostics->Command Prompt
Try to download or upload a file.
It does not work - nothing happens when the download or upload button is pushed.
Pull request for master: https://github.com/pfsense/pfsense/pull/1987
The fix is actually needed in master as well as RELENG_2_2 because the code in master is still using some non-bootstrap for this, so it needs to work just as in RELENG_2_2.
Thanks Phil. I will address this later today. I agree that passing language dependent terms in a POST request is bad. I propose that we separate the display from the value and use one word, capitalized English terms for the latter. e.g.:
<button class="btn btn-sm btn-success" value="SAVE">=gettext("Save")?>></button>
or similar depending on the HTML
- Assignee changed from Phillip Davis to Anonymous
- Status changed from New to Feedback
- Assignee changed from Anonymous to Phillip Davis
Updated as suggested above.
Also added Javascript to scroll the page to the PHP section when a PHP command is executed.
- % Done changed from 0 to 100
2.3-ALPHA (amd64)
built on Mon Oct 26 19:32:58 CDT 2015
FreeBSD 10.2-STABLE
Works
2.2.5-DEVELOPMENT (i386)
built on Mon Oct 26 18:12:44 CDT 2015
FreeBSD 10.1-RELEASE-p23
Works
- Status changed from Feedback to Resolved
Also available in: Atom
PDF