Project

General

Profile

Feature #5387

dhcp server RRD graph

Added by jeroen van breedam about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Category:
RRD Graphs
Target version:
Start date:
11/08/2015
Due date:
% Done:

0%

Estimated time:

Description

after adding the lease_counter to status_dhcp_leases.php, i've tried to get the same data into RRD.

please check PR and if possible provide some feedback
https://github.com/pfsense/pfsense/pull/2036

Associated revisions

Revision ec5b9e96 (diff)
Added by Chris Buechler about 4 years ago

fix invalid foreach with no DHCP server enabled introduced in Ticket #5387

Revision 61237194 (diff)
Added by Chris Buechler about 4 years ago

Clarify description. Ticket #5387

Revision b8316459 (diff)
Added by Chris Buechler about 4 years ago

fix text. Ticket #5387

History

#1 Updated by jeroen van breedam about 4 years ago

steve_b merged the PR above.

i've further improved the graph by adding dhcp-range as a value (= range_to - range_from).
i've also modify the line-styles to make it look better.

the new version can be found here: https://github.com/pfsense/pfsense/pull/2054

#2 Updated by Chris Buechler about 4 years ago

  • Category set to RRD Graphs
  • Status changed from New to Feedback

merged, leaving for verification

#3 Updated by jeroen van breedam about 4 years ago

thanks for merging both PR's.

i'll read about the flaws / bugs / problems when you folks find the time to check it out.

#4 Updated by Chris Buechler about 4 years ago

the menu item for this isn't showing up on any systems I checked, something missed in the merges there? Only had time for a quick glance at the code.

#5 Updated by jeroen van breedam about 4 years ago

services_dhcp.php has a checkbox for each individual interface-tab, to enable the graphs. (graphs are disabled by default).

checkbox is located below 'static arp' & 'time format change'

#6 Updated by jeroen van breedam about 4 years ago

Chris Buechler
thanks for the fixes.
will try to remember/study them, so you don't have to clean up (as much) in future contributions.

#7 Updated by Chris Buechler about 4 years ago

  • Status changed from Feedback to Resolved

this all works, looks good

Also available in: Atom PDF