Project

General

Profile

Actions

Bug #5389

closed
JP JP

system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges

Bug #5389: system_groupmanager.php & system_usermanager.php -- No means to remove assigned privileges

Added by Jim Pingle almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
11/09/2015
Due date:
% Done:

100%

Estimated time:

Description

On system_groupmanager.php & system_usermanager.php assigned privileges have no "delete" icon. Once a privilege is added to a user there is no way to remove it.

Updated by Anonymous almost 11 years ago Actions #2

  • Status changed from Confirmed to Feedback
  • Assignee changed from Anonymous to Jim Pingle

Fixed by PR 2047

JP Updated by Jim Pingle almost 11 years ago Actions #3

  • Status changed from Feedback to Assigned
  • Assignee changed from Jim Pingle to Anonymous

Is that merged? This still isn't working

JV Updated by jeroen van breedam almost 11 years ago Actions #4

its appears to be still 'open' on github

Updated by Anonymous almost 11 years ago Actions #5

  • Status changed from Assigned to Feedback
  • Assignee changed from Anonymous to Jim Pingle

Merged and pushed.

JP Updated by Jim Pingle almost 11 years ago Actions #6

  • Status changed from Feedback to Resolved

Removing individual privileges for users and groups works fine with that as far as I can see. Thanks!

JP Updated by Jim Pingle almost 11 years ago Actions #7

  • Status changed from Resolved to Assigned
  • Assignee changed from Jim Pingle to Anonymous

Looks like there is one little issue here yet or perhaps it crept in after other changes. On system_usermanager.php you can't delete the first or last privilege in the list on a user. The others can be removed without issue.

The same operation works OK on a group.

JP Updated by Jim Pingle almost 11 years ago Actions #8

May just be the first privilege. I had issues deleting the last one but then after deleting some middle ones it worked -- try starting with 5 or so added to a user.

Updated by Anonymous almost 11 years ago Actions #9

  • Status changed from Assigned to Feedback
  • Assignee changed from Anonymous to Jim Pingle

Priv table was incorrectly numbered because privs inherited from a group should not be deletable

Updated by Anonymous almost 11 years ago Actions #10

  • % Done changed from 0 to 100

Applied in changeset pfsense:commit:945204b1590dbd3d8eb774b961b3cfa77d1e9407.

JP Updated by Jim Pingle almost 11 years ago Actions #11

  • Status changed from Feedback to Resolved

Seems to work OK now.

Actions

Also available in: Atom