Bug #5400
closed
diag_ping.php - Following link to pre-fill page results in an incorrect error
100%
Description
If you follow a link, such as one from Diag > DNS Lookup, to diag_ping.php similar to this:
diag_ping.php?host=google.com&interface=wan&count=3
The page loads displaying an error that the host couldn't be resolved or didn't respond, which isn't true the ping just hasn't been done yet (since it shouldn't take action until run via POST)
Updated by jeroen van breedam about 9 years ago
proposed fix:
https://github.com/pfsense/pfsense/pull/2055
Updated by Anonymous about 9 years ago
- Status changed from Confirmed to Feedback
- Assignee changed from Anonymous to Jim Pingle
Fixed by heper:patch-2 PR: 1932 now merged.
Updated by Jim Pingle about 9 years ago
- Status changed from Feedback to Confirmed
- Assignee changed from Jim Pingle to Anonymous
This shouldn't be taking the action on following the link, it should only be pre-filling the form. Automatically taking an action like that on GET isn't desirable.
Updated by Jim Pingle about 9 years ago
- Assignee changed from Anonymous to Jim Pingle
I'll take this, looks like there is a similar problem with traceroute, I've got a fix.
Updated by Jim Pingle about 9 years ago
- Status changed from Confirmed to Feedback
- % Done changed from 0 to 100
Applied in changeset pfsense:ed69a49666fa5f7e9fe1366d9f176ffba15536f1.
Updated by Jim Pingle about 9 years ago
- Status changed from Feedback to Resolved
Looks good here, it's behaving as expected now. No errors on load and it does not take action until the form is submitted.