Project

General

Profile

Bug #5405

Many pages - sorting missing

Added by Jim Pingle over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
11/09/2015
Due date:
% Done:

100%

Estimated time:

Description

The following pages/widgets had sortable output on 2.2.x but are not sortable on 2.3.x

carp_status.php - List of VIPs/status
diag_dump_states.php - State table output
diag_ipsec_leases.php - IPsec mobile user leases
diag_ipsec.php - IPsec tunnel status
diag_ipsec_spd.php - IPsec SPD Entries
diag_ndp.php - Neighbor Discovery Protocol hosts (similar to ARP table)
diag_routes.php - List of IPv4 and IPv6 routes should be separately sortable
diag_sockets.php - List of IPv4 and IPv6 sockets should be separately sortable
services_dnsmasq.php - Host overrides and Domain overrides should be separately sortable
services_unbound_acls.php - ACL list
services_unbound.php - Host overrides and Domain overrides should be separately sortable
status_gateways.php - Gateway list
status_lb_pool.php - LB Pool entries
status_lb_vs.php - LB Virtual Server entries
status_ntpd.php - NTP status server entries
status_openvpn.php - Status entries inside each type
status_services.php - Service list
status_wireless.php - Connected wireless clients
system_authservers.php - Auth server list
system_groupmanager.php - Group list
system_usermanager.php - User list
vpn_openvpn_client.php - OpenVPN Client list
vpn_openvpn_server.php - OpenVPN Server list
widgets/widgets/captive_portal_status.widget.php - Connected Captive Portal clients
widgets/widgets/openvpn.widget.php - Status entries inside each type

I had already opened a couple other tickets for these individually before noticing there were so many.
diag_arp.php - #5400
status_dhcp_leases.php - #5399
status_dhcpv6_leases.php - #5399

Associated revisions

History

#1 Updated by Steve Beaver over 3 years ago

  • Status changed from Confirmed to Feedback
  • Assignee changed from Steve Beaver to Jim Pingle

All three tickets completed.

Note that we still need to add IP address sorting (which is now alphanumeric). Making a new ticket for that one.

#2 Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Jim Pingle to Steve Beaver
  • % Done changed from 0 to 70

Most of them appear to be working OK, but a few issues yet:

diag_routes.php - Column headers appear to be clickable but no sorting happens and no sort order indicators show up
status_lb_vs.php - No sorting at all
status_wireless.php - Nearby AP table is sortable but not "Associated or ad-hoc peers"
system_usermanager.php - Column headers are clickable, sort order arrows show up, but table contents do not sort
widgets/widgets/openvpn.widget.php - Some parts are sortable but not "Peer to Peer Service Instance Statistics" and "Client Instance Statistics"

diag_ipsec_leases.php - Still needs testing, unrelated issue with the page yet in master at the moment

#3 Updated by Steve Beaver over 3 years ago

All static tables are working correctly, but tables that are populated dynamically via Javascript are not. Investigating . .

#4 Updated by Steve Beaver over 3 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from Steve Beaver to Jim Pingle

Interestingly this sorting library only works correctly if the table is perfectly formatted with all of the proper tags. In some of the pages that did not work there were very old bugs in the way the table was dynamically created which introduce bonus tags. Browsers don't care but the sorting library does.
diag_routes.php no longer sorts.

#5 Updated by Steve Beaver over 3 years ago

  • % Done changed from 70 to 100

#6 Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Jim Pingle to Steve Beaver
  • % Done changed from 100 to 90

All fixed but one now:

status_lb_vs.php - Column headers appear to be clickable but no sorting happens

I've got one of my VMs setup to test if you need data, it's the one on 34444

#7 Updated by Steve Beaver over 3 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from Steve Beaver to Jim Pingle

status_lb_vs.php was missing thead/tbody tags. Now sorts correctly.

#8 Updated by Steve Beaver over 3 years ago

  • % Done changed from 90 to 100

#9 Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Resolved

That one works now, too, thanks!

Also available in: Atom PDF