Project

General

Profile

Bug #5411

Lost source negation on firewall_nat_edit.php

Added by Chris Buechler over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Target version:
Start date:
11/10/2015
Due date:
% Done:

100%

Estimated time:

Description

The "not" option for source on firewall_nat_edit.php no longer exists.

NAT-port-forward-edit-225.png (68.6 KB) NAT-port-forward-edit-225.png Phillip Davis, 11/11/2015 06:05 AM

Associated revisions

Revision 0dbf9cbe (diff)
Added by Phillip Davis over 3 years ago

Fix #5411 firewall_nat_edit source negation

And make the "not" checkboxes have the same layout as in firewall_rules_edit. That seems a better place to put the checkbox and consistency between similar GUI screens seems a good thing.

Revision 9a3b6f7f (diff)
Added by Phillip Davis over 3 years ago

Fix #5411 firewall_nat_edit source negation

And make the "not" checkboxes have the same layout as in firewall_rules_edit. That seems a better place to put the checkbox and consistency between similar GUI screens seems a good thing.

History

#1 Updated by jeroen van breedam over 3 years ago

i cannot find the "not" option for source in 2.2.5 or 2.1.4

#2 Updated by Phillip Davis over 3 years ago

Source "not" is there on 2.2.5 - Firewall->NAT Port Forward, Edit an entry. Click the "Advanced" button to show the Source settings.
Destination also has the "not" checkbox.

On current 2.3-ALPHA there is no "Advanced" box for the source settings - they are displayed immediately the screen renders.
The only "not" checkbox is below the Destination settings - and that could be clearer that that "not" checkbox applies to the Destination values.

#3 Updated by Phillip Davis over 3 years ago

Pull request https://github.com/pfsense/pfsense/pull/2058
I made the "not" checkboxes have the label "Invert match" and positioning the same way as in firewall_rules_edit.

#4 Updated by Steve Beaver over 3 years ago

  • Status changed from Confirmed to Feedback
  • Assignee changed from Steve Beaver to Chris Buechler

Fixed y Phil Davis PR 5058

#5 Updated by Phillip Davis over 3 years ago

  • % Done changed from 0 to 100

#7 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

works

Also available in: Atom PDF