Project

General

Profile

Bug #5502

Warning: file_put_contents(): Filename cannot be empty in /etc/inc/pkg-utils.inc on line 123

Added by Phillip Davis over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Package System
Target version:
Start date:
11/20/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

After doing a reset to factory defaults, then config restore to put my test system back the way it was, the bootup installs the necessary packages. In this case I only had Cron package to install. The console reports:

Updating pfSense-core repository catalogue... metadata and fini package reinstallation
pfSense-core repository is up-to-date.
Updating pfSense repository catalogue...
pfSense repository is up-to-date.
All repositories are up-to-date.

Warning: file_put_contents(): Filename cannot be empty in /etc/inc/pkg-utils.inc on line 123

Call Stack:
0.0088 213808 1. {main}() /etc/rc.bootup:0
46.1314 1287848 2. package_reinstall_all() /etc/rc.bootup:399
46.1319 1288048 3. pkg_update() /etc/inc/pkg-utils.inc:973
51.4878 1288680 4. file_put_contents() /etc/inc/pkg-utils.inc:123

Updating package repository metadada...
Updating pfSense-core repository catalogue...
pfSense-core repository is up-to-date.
Updating pfSense repository catalogue...
pfSense repository is up-to-date.
All repositories are up-to-date.
done (0 conflicting)
The following 1 package(s) will be affected (of 0 checked):

Installed packages to be REINSTALLED:
pfSense-pkg-Cron-0.3.2 [pfSense]
[1/1] Reinstalling pfSense-pkg-Cron-0.3.2...

and so on.
Cron gets installed fine. I can't see any actual "bad thing" that has happened due to this PHP warning.

The code there is like:
if ($rc) {
file_put_contents($last_update_file, $now . "\n");
}

But $last_update_file is only defined inside a different "if" statement higher up, so it can sometimes be empty.

Associated revisions

Revision b5b51aa6 (diff)
Added by Renato Botelho over 3 years ago

Always define $last_update_file to avoid calling file_put_contents with empty filename. Fixes #5502

History

#1 Updated by Renato Botelho over 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#2 Updated by Phillip Davis over 3 years ago

Fixed

Sample console output now on config restore/reboot/package reinstall:

Generating RRD graphs...done.
Updating pfSense-core repository catalogue... metadata and fini package reinstallation
doneing meta.txz: .
Fetching packagesite.txz: . done
. donesing entries:
pfSense-core repository update completed. 10 packages processed.
Updating pfSense repository catalogue...
pfSense repository is up-to-date.

Updating package repository metadada...
done (0 conflicting)
The following 1 package(s) will be affected (of 0 checked):

Installed packages to be REINSTALLED:
pfSense-pkg-Cron-0.3.2 [pfSense]
[1/1] Reinstalling pfSense-pkg-Cron-0.3.2...

on so on...

#3 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF