Bug #5654
closed
services_dhcp.php available range missing end of range
Added by Chris Buechler almost 9 years ago.
Updated almost 9 years ago.
Description
"Available range" on services_dhcp.php is missing the end of the range. For instance on the default 192.168.1.1/24 LAN interface, it should show 192.168.1.1 - 192.168.1.254, and it shows "192.168.1.1 - " currently.
On a 2.2.5 system:
$ifcfgip = "192.168.1.1";
$ifcfgsn = 24;
$y = gen_subnet($ifcfgip, $ifcfgsn);
var_dump($y);
$x = gen_subnet_max($ifcfgip, $ifcfgsn);
var_dump($x);
string(11) "192.168.1.0"
string(13) "192.168.1.255"
On 2.3:
string(11) "192.168.1.0"
string(0) ""
So gen_subnet_max and... that calculates the top end of a subnet is broken.
I will have a little look now.
- Assignee deleted (
Anonymous)
Thanks Phil. Figure it's probably not all that difficult, but I'm in the middle of a slew of other things at the moment.
Not a Bootstrap issue so I'll put it to unassigned (and you're welcome to pick up anything that's assigned to anyone else anyway).
- Status changed from Confirmed to Feedback
- Assignee set to Chris Buechler
Corrected by Phil Davis PR 2291
- Status changed from Feedback to Resolved
Also available in: Atom
PDF