Bug #568
closed
firewall rules advanced clean up
0%
Description
The new advanced hiding, and splitting the screen into two parts, really messes up working with rules with advanced options. Needs to:
1) If any advanced option is non-default, get rid of the first save/cancel buttons and show the advanced options before showing save.
2) For any non-default advanced option, do not hide it behind an advanced button, so you can actually see what parts are configured without clicking 10 advanced buttons.
Updated by Erik Fonnesbeck over 14 years ago
Having the PHP output javascript for unhiding them when the conditions are met might be the best way to do this. When working with the port forwards edit page, which uses an external .js file, I found that just removing the properties that hid something by default didn't quite work, because some other script was still hiding it.
Updated by Ermal Luçi
Updated by Seth Mos over 14 years ago
Is it not easier to just tag all set fields in the css class as being an unhidden type? That means far less code. the css can handle the hide/unhide of a field depending on if it has a value or not.
so instead of a class "formfld" a "formfld.hidden" etc.
Normally I'd ask Holger. Not sure if he's still around.
Updated by Chris Buechler over 14 years ago
- Status changed from Feedback to New
- Priority changed from Normal to Very Low
- 2 mentioned in the initial ticket looks to be good now. # 1 needs to be addressed.
Updated by Scott Ullrich over 14 years ago
How about just removing the first save / cancel button altogether?
Updated by Chris Buechler over 14 years ago
that'd be adequate. As is, I've heard from several users who are confused about the advanced options because of the two save buttons.
Updated by Chris Buechler about 14 years ago
- Status changed from Feedback to Resolved