Project

General

Profile

Bug #568

firewall rules advanced clean up

Added by Chris Buechler about 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
-
Category:
Rules/NAT
Target version:
Start date:
05/02/2010
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

The new advanced hiding, and splitting the screen into two parts, really messes up working with rules with advanced options. Needs to:

1) If any advanced option is non-default, get rid of the first save/cancel buttons and show the advanced options before showing save.
2) For any non-default advanced option, do not hide it behind an advanced button, so you can actually see what parts are configured without clicking 10 advanced buttons.

Associated revisions

Revision 8ba13f00 (diff)
Added by Ermal Luçi about 9 years ago

Ticket #568. Programatically decide if to show an advanced button or the value if non default.

Revision 8e0c3760 (diff)
Added by Ermal Luçi over 8 years ago

Ticket #568. Do not show the save/cancel buttons on the edit page of firewall rules if that are advanced options set.

History

#1 Updated by Erik Fonnesbeck about 9 years ago

Having the PHP output javascript for unhiding them when the conditions are met might be the best way to do this. When working with the port forwards edit page, which uses an external .js file, I found that just removing the properties that hid something by default didn't quite work, because some other script was still hiding it.

#2 Updated by Ermal Luçi about 9 years ago

  • Status changed from New to Feedback

#3 Updated by Seth Mos about 9 years ago

Is it not easier to just tag all set fields in the css class as being an unhidden type? That means far less code. the css can handle the hide/unhide of a field depending on if it has a value or not.

so instead of a class "formfld" a "formfld.hidden" etc.

Normally I'd ask Holger. Not sure if he's still around.

#4 Updated by Chris Buechler almost 9 years ago

  • Status changed from Feedback to New
  • Priority changed from Normal to Very Low
  1. 2 mentioned in the initial ticket looks to be good now. # 1 needs to be addressed.

#5 Updated by Scott Ullrich almost 9 years ago

How about just removing the first save / cancel button altogether?

#6 Updated by Chris Buechler almost 9 years ago

that'd be adequate. As is, I've heard from several users who are confused about the advanced options because of the two save buttons.

#7 Updated by Ermal Luçi over 8 years ago

  • Status changed from New to Feedback

#8 Updated by Chris Buechler over 8 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF