Project

General

Profile

Bug #5788

Inconsistent information box behaviour on firewall_rules.php

Added by Marco Novielli over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
Start date:
01/20/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

The information box on firewall_rules.php can be X'd out, which then removes the ability to access it again until a refresh of the page. This is inconsistent with other pages such as firewall_schedule.php, which only have an "I" button toggle (preferred approach in my opinion). If nothing else, for consistency.

I hope this makes sense. I have attached screenshots.

firewall.png (105 KB) firewall.png Bug Marco Novielli, 01/20/2016 05:29 PM
preferred.tiff (47.5 KB) preferred.tiff Preferred, as on other pages. Marco Novielli, 01/20/2016 05:29 PM

History

#1 Updated by Steve Beaver over 3 years ago

You may have a less up to date version. That page was converted to the "infbox" scheme some time ago and now displays the 'i' icon as you describe.

#2 Updated by Steve Beaver over 3 years ago

  • Status changed from New to Feedback
  • Assignee set to Marco Novielli

#3 Updated by Marco Novielli over 3 years ago

Yes, they both have the 'i' icon, but why is there an X option to close this on this page (top right of infoblox), and other pages with infoblox do not have the X option (such as firewall_schedule)? I think it should be consistent between pages, and I personally prefer only having the 'i' icon to toggle the infoblox open and close.

Minor at the end of the day, but I am a bit OCD.

#4 Updated by Phillip Davis over 3 years ago

The infoblock in Firewall Rules was a bit special and had a hard-coded close button.
Removed by PR https://github.com/pfsense/pfsense/pull/2490

#5 Updated by Steve Beaver over 3 years ago

Thanks Phil. I failed to notice that :(

I'll be merging your change shortly.

#6 Updated by Marco Novielli over 3 years ago

Looks good to me. Thanks guys!

#7 Updated by Renato Botelho over 3 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF