Project

General

Profile

Actions
Copy link

Bug #5788

closed
MN MN

Inconsistent information box behaviour on firewall_rules.php

Bug #5788: Inconsistent information box behaviour on firewall_rules.php

Added by Marco Novielli over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Marco Novielli
Category:
Web Interface
Target version:
2.3
Start date:
01/20/2016
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3
Affected Architecture:

Description

The information box on firewall_rules.php can be X'd out, which then removes the ability to access it again until a refresh of the page. This is inconsistent with other pages such as firewall_schedule.php, which only have an "I" button toggle (preferred approach in my opinion). If nothing else, for consistency.

I hope this makes sense. I have attached screenshots.

Files

Download all files
firewall.png (105 KB) firewall.png Bug Marco Novielli, 01/20/2016 05:29 PM
preferred.tiff (47.5 KB) preferred.tiff Preferred, as on other pages. Marco Novielli, 01/20/2016 05:29 PM

Updated by Anonymous over 10 years ago Actions
Copy link
 #1

You may have a less up to date version. That page was converted to the "infbox" scheme some time ago and now displays the 'i' icon as you describe.

Updated by Anonymous over 10 years ago Actions
Copy link
 #2

  • Status changed from New to Feedback
  • Assignee set to Marco Novielli

MN Updated by Marco Novielli over 10 years ago Actions
Copy link
 #3

Yes, they both have the 'i' icon, but why is there an X option to close this on this page (top right of infoblox), and other pages with infoblox do not have the X option (such as firewall_schedule)? I think it should be consistent between pages, and I personally prefer only having the 'i' icon to toggle the infoblox open and close.

Minor at the end of the day, but I am a bit OCD.

PD Updated by Phillip Davis over 10 years ago Actions
Copy link
 #4

The infoblock in Firewall Rules was a bit special and had a hard-coded close button.
Removed by PR https://github.com/pfsense/pfsense/pull/2490

Updated by Anonymous over 10 years ago Actions
Copy link
 #5

Thanks Phil. I failed to notice that :(

I'll be merging your change shortly.

MN Updated by Marco Novielli over 10 years ago Actions
Copy link
 #6

Looks good to me. Thanks guys!

RB Updated by Renato Botelho over 10 years ago Actions
Copy link
 #7

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom