Bug #5828
closed
firewall_nat_out.php enabled/disabled status not shown
Added by Chris Buechler about 10 years ago.
Updated about 10 years ago.
Description
The NAT rules on firewall_nat_out.php should be grayed out when disabled, same as firewall_nat.php and others.
Additionally, firewall_nat_out.php lost showing all NAT rules as disabled when non-applicable as it did in 2.2.x. If mode is Automatic or Disable, then all rules should show as disabled.
- Status changed from Confirmed to Feedback
- Assignee set to Chris Buechler
Appropriate code has now been added here.
- % Done changed from 0 to 100
Applied in changeset commit:1cd1435e8594c06bee8c4ac61edce9cec86af137.
This all looks good to me now after Steve B's fixes. The rules were marked disabled before but the only indication was that the icon on the left changed from a check (enabled) to an X (disabled) so it was easy to miss that they were showing disabled. Now they are also greyed out so it's more obvious and closer to the 2.2.x behavior. I tested rules in each mode plus toggling a rule in manual outbound NAT to see a single rule disabled, all cases looked OK.
Was there some other case where they didn't show as being disabled with an 'x'? If so, I wasn't able replicate that here.
- Status changed from Feedback to Resolved
This is all good now. The X was there, I just didn't notice it, was expecting it to be grayed out like it used to be and is now.
Also available in: Atom
PDF
Updated by Anonymous 
Updated by 
Updated by