Project

General

Profile

Bug #5882

XMLRPC sync tests for DNS Forwarder and Resolver are incorrect, will disable one in a valid configuration

Added by Jim Pingle almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
XMLRPC
Target version:
Start date:
02/11/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3
Affected Architecture:
All

Description

The tests at source:src/usr/local/www/xmlrpc.php#L214 are making faulty assumptions. The test assumes that only one or the other of the DNS Resolver or Forwarder can be enabled, and that they are on the same port.

In reality, the two do not conflict when run on separate ports and they can both be enabled simultaneously. A conflict only exists if both are enabled and attempting to run on the same port.

The current tests must be split into separate test blocks for unbound and dnsmasq (independent from one another) and the tests to determine if the other service should be disabled must be changed to account for comparing the port numbers to determine if there is a true conflict.

The end result with the current code is that only one service can be run on the secondary with XMLRPC config sync enabled, the other will be incorrectly disabled.

Associated revisions

Revision 57b5da70 (diff)
Added by Jim Pingle almost 4 years ago

Refine the way the DNS Forwarder and DNS Resolver are handled via XMLRPC. Fixes #5882

History

#1 Updated by Jim Pingle almost 4 years ago

  • Description updated (diff)

#2 Updated by Jim Pingle almost 4 years ago

  • Description updated (diff)

#3 Updated by Jim Pingle almost 4 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

#4 Updated by Jim Thompson almost 4 years ago

  • Assignee set to Jim Pingle

#5 Updated by Jim Pingle almost 4 years ago

  • Status changed from Feedback to Resolved

Updated and tested this again each way (one enabled, the other enabled, both enabled, etc) and each time the behavior was correct after my last change. The services are started and stopped as expected now.

Also available in: Atom PDF