Bug #5890: "External config loader" not loading config.xml from USB at boot - pfSense - pfSense bugtracker

Actions

Copy link

Bug #5890

closed

"External config loader" not loading config.xml from USB at boot

Added by Nick Holloway about 9 years ago. Updated over 5 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Category:

XMLRPC

Target version:

Start date:

02/14/2016

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

2.2.5

Affected Architecture:

Description

I was looking at how pfSense can restore configuration if we needed to switch to new hardware.

Looking at "/etc/ecl.php", I can see that the intent is for pfSense to check for "config.xml" on disks present at boot (USB) and to restore the configuration found there.

When booting, the only output you see is:

External config loader 1.0 is now starting...

The function 'get_disk_slices' attempts to discover slices by using "/bin/ls /dev/{$disk}s*". However, commit 873c1701 added "escapeshellarg" around this call, so the wildcard is not expanded.

I have a fix (pull request to follow) which uses "glob" for the wildcard expansion, without using external call to "ls".

A test boot (of pfSense embedded inside VM) is now:

External config loader 1.0 is now starting... da0s1 -> found config.xml
Backing up old configuration...
Restoring [da0s1] /tmp/mnt/cf/config.xml...
Cleaning up...