Project

General

Profile

Actions
Copy link

Bug #5916

closed
MF MF

General Setup page cannot be saved with blank DNS server slots

Bug #5916: General Setup page cannot be saved with blank DNS server slots

Added by Mark Furneaux over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Mark Furneaux
Category:
Web Interface
Target version:
2.3
Start date:
02/20/2016
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3
Affected Architecture:
All

Description

If there are 2 or more blank DNS server addresses on the System/General Setup page, saving the page will result in the following error:

The following input errors were detected:
Each configured DNS server must have a unique IP address. Remove the duplicated IP.

The sanitizer doesn't seem to ignore blank fields anymore.

PD Updated by Phillip Davis over 10 years ago Actions
Copy link
 #2

Now I see that there is an alternative solution already in pull request https://github.com/pfsense/pfsense/pull/2678
Take your pick.

PD Updated by Phillip Davis over 10 years ago Actions
Copy link
 #3

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:bdfe939c4e1d30ba0d10bd6b9e995f1129bb483e.

Updated by Anonymous over 10 years ago Actions
Copy link
 #4

  • Status changed from Feedback to Resolved

No harm in applying both.

Updated by Anonymous over 10 years ago Actions
Copy link
 #5

  • Status changed from Resolved to Feedback
  • Assignee set to Mark Furneaux

MF Updated by Mark Furneaux over 10 years ago Actions
Copy link
 #6

Actually there is harm in both. The change in https://github.com/pfsense/pfsense/pull/2680 will cause a crash if all DNS server slots are empty when array_filter() is called. One of the two patches needs to be reverted.

MF Updated by Mark Furneaux over 10 years ago Actions
Copy link
 #7

On a second look, 2680 will always crash when no servers are populated, so it is the one which must be reverted.

Updated by Anonymous over 10 years ago Actions
Copy link
 #8

2680 reverted.

MF Updated by Mark Furneaux over 10 years ago Actions
Copy link
 #9

Tested in 2.3.b.20160226.1008 and everything looks good. I think this can be closed.

CB Updated by Chris Buechler over 10 years ago Actions
Copy link
 #10

  • Category set to Web Interface
  • Status changed from Feedback to Resolved
  • Target version set to 2.3

yeah this is all good, thanks! pointy hat to me for not thinking of this use case

Actions
Copy link

Also available in: Atom