Bug #5916
closed
General Setup page cannot be saved with blank DNS server slots
100%
Description
If there are 2 or more blank DNS server addresses on the System/General Setup page, saving the page will result in the following error:
The following input errors were detected: Each configured DNS server must have a unique IP address. Remove the duplicated IP.
The sanitizer doesn't seem to ignore blank fields anymore.
Updated by Phillip Davis almost 10 years ago
This helps: https://github.com/pfsense/pfsense/pull/2680
Updated by Phillip Davis almost 10 years ago
Now I see that there is an alternative solution already in pull request https://github.com/pfsense/pfsense/pull/2678
Take your pick.
Updated by Phillip Davis almost 10 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset bdfe939c4e1d30ba0d10bd6b9e995f1129bb483e.
Updated by Anonymous almost 10 years ago
- Status changed from Feedback to Resolved
No harm in applying both.
Updated by Anonymous almost 10 years ago
- Status changed from Resolved to Feedback
- Assignee set to Mark Furneaux
Updated by Mark Furneaux almost 10 years ago
Actually there is harm in both. The change in https://github.com/pfsense/pfsense/pull/2680 will cause a crash if all DNS server slots are empty when array_filter() is called. One of the two patches needs to be reverted.
Updated by Mark Furneaux almost 10 years ago
On a second look, 2680 will always crash when no servers are populated, so it is the one which must be reverted.
Updated by Mark Furneaux almost 10 years ago
Tested in 2.3.b.20160226.1008 and everything looks good. I think this can be closed.
Updated by Chris Buechler almost 10 years ago
- Category set to Web Interface
- Status changed from Feedback to Resolved
- Target version set to 2.3
yeah this is all good, thanks! pointy hat to me for not thinking of this use case