Project

General

Profile

Bug #5916

General Setup page cannot be saved with blank DNS server slots

Added by Mark Furneaux about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
02/20/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3
Affected Architecture:
All

Description

If there are 2 or more blank DNS server addresses on the System/General Setup page, saving the page will result in the following error:

The following input errors were detected:
Each configured DNS server must have a unique IP address. Remove the duplicated IP.

The sanitizer doesn't seem to ignore blank fields anymore.

Associated revisions

Revision bdfe939c (diff)
Added by Phillip Davis about 3 years ago

Fix #5916 Do not complain about duplicated blank DNS server entries

Reported by redmine https://redmine.pfsense.org/issues/5916

History

#2 Updated by Phillip Davis about 3 years ago

Now I see that there is an alternative solution already in pull request https://github.com/pfsense/pfsense/pull/2678
Take your pick.

#3 Updated by Phillip Davis about 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#4 Updated by Steve Beaver about 3 years ago

  • Status changed from Feedback to Resolved

No harm in applying both.

#5 Updated by Steve Beaver about 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee set to Mark Furneaux

#6 Updated by Mark Furneaux about 3 years ago

Actually there is harm in both. The change in https://github.com/pfsense/pfsense/pull/2680 will cause a crash if all DNS server slots are empty when array_filter() is called. One of the two patches needs to be reverted.

#7 Updated by Mark Furneaux about 3 years ago

On a second look, 2680 will always crash when no servers are populated, so it is the one which must be reverted.

#8 Updated by Steve Beaver about 3 years ago

2680 reverted.

#9 Updated by Mark Furneaux about 3 years ago

Tested in 2.3.b.20160226.1008 and everything looks good. I think this can be closed.

#10 Updated by Chris Buechler about 3 years ago

  • Category set to Web Interface
  • Status changed from Feedback to Resolved
  • Target version set to 2.3

yeah this is all good, thanks! pointy hat to me for not thinking of this use case

Also available in: Atom PDF