Project

General

Profile

Actions
Copy link

Bug #6089

closed
PD PD

PHP warning when saving client-specific override with no server selected.

Bug #6089: PHP warning when saving client-specific override with no server selected.

Added by Phillip Davis over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Phillip Davis
Category:
OpenVPN
Target version:
2.3
Start date:
04/07/2016
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3
Affected Architecture:

Description

Add an OpenVPN Client Specific Override, and do not select any server (so it should apply to all servers).
A crash report is generated like:
PHP Errors:
PHP Stack trace:
PHP 1. {main}() /usr/local/www/vpn_openvpn_csc.php:0
PHP 2. implode() /usr/local/www/vpn_openvpn_csc.php:243

Interestingly, the Client Specific Override is saved, so the problem with implode() at line 243 is not stopping further PHP execution.

Reported in forum https://forum.pfsense.org/index.php?topic=109431.msg0

CB Updated by Chris Buechler over 10 years ago Actions
Copy link
 #2

  • Status changed from New to Feedback

merged, thanks Phil

PD Updated by Phillip Davis over 10 years ago Actions
Copy link
 #3

It works for me, but some independent person should test it and then mark this resolved.

CP Updated by Chris Palmer over 10 years ago Actions
Copy link
 #4

Works for me as well.

CP Updated by Chris Palmer over 10 years ago Actions
Copy link
 #5

But when I deleted the override I got this-

Crash report details:

PHP Errors:
[07-Apr-2016 19:59:19 America/Vancouver] PHP Stack trace:
[07-Apr-2016 19:59:19 America/Vancouver] PHP 1. {main}() /usr/local/www/vpn_openvpn_csc.php:0
[07-Apr-2016 19:59:19 America/Vancouver] PHP 2. implode() /usr/local/www/vpn_openvpn_csc.php:243

Filename: /var/crash/minfree

PD Updated by Phillip Davis over 10 years ago Actions
Copy link
 #6

I tried to reproduce that, but no success.
Are you sure that you have the new code on your system? Because the implode() code is no longer at line 243.

CP Updated by Chris Palmer over 10 years ago Actions
Copy link
 #7

Ah- Hadn't synced that particular box... Your right.

Ill gitsync and go again.

CP Updated by Chris Palmer over 10 years ago Actions
Copy link
 #8

Synced and no errors this time.

PD Updated by Phillip Davis over 10 years ago Actions
Copy link
 #9

Good to hear.

CB Updated by Chris Buechler over 10 years ago Actions
Copy link
 #10

  • Status changed from Feedback to Resolved

Also could replicate before and not after. Fixed, thanks!

Actions
Copy link

Also available in: Atom