Project

General

Profile

Bug #6278

Captive Portal zone name is case sensitive in some places, but not carried through as expected

Added by Jim Pingle over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
Captive Portal
Target version:
Start date:
04/27/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

There are a couple cases that show problems with Captive Portal with respect to the zone name on 2.3 which were working correctly on 2.2.x.

Notably, the zone parameter is being passed in lowercase, which fails to match when the zone name on pfSense is capitalized. One example here: https://forum.pfsense.org/index.php?topic=110415.0

Similar problems can also affect the pre-auth redirect mechanism.

As a temporary workaround, changing the zone name on pfSense in the config.xml allows it to function.

It doesn't seem like the zone name should be case sensitive anyhow, perhaps all zone name comparisons should be changed to be case insensitive.

Associated revisions

Revision 0c388fef (diff)
Added by Renato Botelho over 3 years ago

Fix #6278

$cpzone is always in lowercase, it's used as the array key used in
config.xml. Use it in two cases where the $cp['zone'] was being wrongly
used:

- To find out zoneid
- To replace PORTAL_ACTION url

Revision 7949eac7 (diff)
Added by Renato Botelho over 3 years ago

Add a safebelt to makesure $cpzone is always in lowercase. Ticket #6278

Revision 26c7100b (diff)
Added by Renato Botelho over 3 years ago

Fix #6278

$cpzone is always in lowercase, it's used as the array key used in
config.xml. Use it in two cases where the $cp['zone'] was being wrongly
used:

- To find out zoneid
- To replace PORTAL_ACTION url

Revision eb29a44a (diff)
Added by Renato Botelho over 3 years ago

Add a safebelt to makesure $cpzone is always in lowercase. Ticket #6278

History

#1 Updated by Renato Botelho over 3 years ago

  • Assignee set to Renato Botelho

#2 Updated by Renato Botelho over 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

works

Also available in: Atom PDF