Project

General

Profile

Bug #6291

Serial console data fields not displayed on nanobsd VGA

Added by Phillip Davis over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
Start date:
04/29/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

Reported in forum: https://forum.pfsense.org/index.php?topic=111006.0

In system_advanced_admin.php the fileds enableserial primaryconsole do not seem to display for the nanobsd VGA case.

The condition for displaying these fields in 2.2.* was here:
https://github.com/pfsense/pfsense/blob/RELENG_2_2/usr/local/www/system_advanced_admin.php#L518

and contained the extra test:
file_exists("/etc/nano_use_vga.txt")

The current code in 2.3 is missing this test.

I don't have a way to try on a nanobsd VGA system, so I will leave it for someone else to decide if the old test can just be pasted back in, or if a different test is now needed.

Associated revisions

Revision 2a884911 (diff)
Added by Renato Botelho over 3 years ago

Do not check platform to decide if enableserial and primaryconsole fields will be hidden, global parameters are the rule to decide it. Fixes #6291

Revision 1729ee29 (diff)
Added by Renato Botelho over 3 years ago

Do not check platform to decide if enableserial and primaryconsole fields will be hidden, global parameters are the rule to decide it. Fixes #6291

History

#1 Updated by Chris Buechler over 3 years ago

  • Status changed from New to Confirmed
  • Target version changed from 2.3.1 to 2.3.2

there is no nano_use_vga.txt in 2.3. Not sure offhand if that's intentional

#2 Updated by Renato Botelho over 3 years ago

  • Assignee set to Renato Botelho

It was replaced by $g['enableserial_force']. I've pushed a fix for System Advanced page

#3 Updated by Renato Botelho over 3 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

#4 Updated by Renato Botelho over 3 years ago

  • Status changed from Feedback to Resolved

works

Also available in: Atom PDF