Bug #6635
closed
Dyndns not updating for no-ip
0%
Description
There's a typo on line 431 of dyndns.class where '&h[]=' should be '&hostname='. As is, it doesn't update and logs an error message of "(Error) Invalid Password." The corrected line should read:
curl_setopt($ch, CURLOPT_URL, $server . $port . '?username=' . urlencode($this->_dnsUser) . '&pass=' . urlencode($this->_dnsPass) . '&hostname=' . $this->_dnsHost.'&ip=' . $iptoset);
Updated by Phillip Davis over 8 years ago
It was "&hostname=" for many years up until 30 Jan 2016, when this commit changed it for some reason:
https://github.com/pfsense/pfsense/commit/70a84c25760dca8a3db8b78ee273216c522cc0e7
Updated by Chris Buechler over 8 years ago
Could have sworn I'd used my no-ip account for testing since that commit. Though my account isn't working either way at the moment. I'm thinking that change might only work with @ in the hostname. will look at it more later.
Updated by Chris Palmer over 8 years ago
My updates on several boxes are working fine. 2.3.1 p5 (I use noip for my primary server dns also so have the paid service.)
24.113.xx.xx 2016-07-07 01:01:04 DUC
24.113.xx.xx 2016-07-07 01:01:04 DUC
Updated by Chris Buechler over 8 years ago
- Status changed from New to Not a Bug
- Affected Version deleted (
2.3.x)
It works fine as-is. Their old API apparently accepts either hostname or h[] there, since it worked before, and it still works fine now. There are references all over the place to doing it the same way we have it, like https://dev.openwrt.org/ticket/9160
That said, the API we're using was replaced in 2011, so we ought to update it to the new one. Opened todo #6638 for that.