Bug #6702
Command Prompt syntax error and crash detection report
100%
Description
syntax error in the PHP execution in Command Prompt menu
should not cause a crash detection to suggest reporting to pfSense
(My list of bugs is at http://reedmedia.net/books/pfsense/bugs-20160813.html )
Associated revisions
Suppress error logging for Diag > Command Prompt so an error in user-entered code doesn't offer to submit a crash report. A notice is still generated since PHP <7 doesn't yet have error_clear_last(). Fixes #6702
Suppress error logging for Diag > Command Prompt so an error in user-entered code doesn't offer to submit a crash report. A notice is still generated since PHP <7 doesn't yet have error_clear_last(). Fixes #6702
Suppress error logging for Diag > Command Prompt so an error in user-entered code doesn't offer to submit a crash report. A notice is still generated since PHP <7 doesn't yet have error_clear_last(). Fixes #6702
History
#1
Updated by Jim Thompson almost 2 years ago
- Status changed from New to Feedback
this needs more detail.
#2
Updated by Kill Bill over 1 year ago
Well I think what was meant here is that pasting random potentially broken junk to Diagnostics - Command Prompt for testing should not offer to submit the resulting crash to you, b/c putting broken code there is no bug to investigate in the first place. Not sure how doable it is.
#3
Updated by Jim Pingle over 1 year ago
- Project changed from pfSense Packages to pfSense
- Category set to Web Interface
- Assignee set to Jim Pingle
- Target version set to 2.4.0
- Affected Version set to All
- Affected Architecture set to All
Pushed a small change so that it will at least not offer to submit a crash report.
#4
Updated by Jim Pingle over 1 year ago
- % Done changed from 0 to 100
Applied in changeset 45bcbee917920238248a2486a2742e3ff327b309.
#5
Updated by Kill Bill over 1 year ago
Yup, works. (As for the error being shown in "PHP Response", I think that's OK and should actually stay, it's useful.)
#6
Updated by Jim Pingle over 1 year ago
- Status changed from Feedback to Resolved
Yeah that's part is good to stay, what still annoys me is that you get a notice from it (alert bell, e-mail notification, etc).
But the way we hook in the part to generate notices from PHP there isn't a good way to bypass that yet in PHP without ugly hackery.
#7
Updated by Jim Pingle over 1 year ago
- Target version changed from 2.4.0 to 2.3.3