Project

General

Profile

Actions
Copy link

Bug #6806

closed
EH EH

Form validation for DHCP NTP Servers does not allow hyphens

Bug #6806: Form validation for DHCP NTP Servers does not allow hyphens

Added by Edward Hurtig almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Edward Hurtig
Category:
Dashboard
Target version:
2.3.3
Start date:
09/21/2016
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3.2
Affected Architecture:

Description

Form validation in the dashboard does not use the proper regex for FQDNs (it doesn't allow hyphens)

<input class="form-control" name="ntp2" id="ntp2" value="1.north-america.pool.ntp.org" pattern="[.a-zA-Z0-9_]+" type="text">

While we're on it, the underscore should probably be removed as underscores are not allowed in hostnames or FQDNs (RFC 1123)

<input class="form-control" name="ntp2" id="ntp2" value="1.north-america.pool.ntp.org" pattern="[.a-zA-Z0-9-]+" type="text">

Files

Screenshot from 2016-09-22 00-32-38.png (8.47 KB) Screenshot from 2016-09-22 00-32-38.png Edward Hurtig, 09/21/2016 11:33 PM

EH Updated by Edward Hurtig almost 10 years ago Actions
Copy link
 #1

https://github.com/pfsense/pfsense/pull/3151 (CLA was just signed so might not be labeled appropriately yet)

Updated by Anonymous almost 10 years ago Actions
Copy link
 #2

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:c68dbfc7580180cd9d47bdbecaeeb6cf835fe210.

JP Updated by Jim Pingle over 9 years ago Actions
Copy link
 #3

  • Assignee set to Edward Hurtig
  • Target version set to 2.3.3

RB Updated by Renato Botelho over 9 years ago Actions
Copy link
 #4

  • Status changed from Feedback to Resolved

works

Actions
Copy link

Also available in: Atom