Project

General

Profile

Actions

Bug #6890

closed

PPP service name error

Added by Jonathan Valverde almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Category:
PPP Interfaces
Target version:
Start date:
11/03/2016
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3.2
Affected Architecture:
amd64

Description

Hi,
I've just updated a virtual appliance to the new 2.3.2_1 version, and now, i can't add ppp connection (3G backup )
I've got a service name mandatory field but it doesn't appear (as in PPPoE mode) and is not mandatory...

Can you help me to find a solution?

Thanks,
JV

Actions #1

Updated by Jim Thompson almost 5 years ago

  • Assignee set to Renato Botelho
Actions #2

Updated by Daniel Weeber over 4 years ago

Having the same problem. cannot add any ppp connection because it's saying "The service name contains invalid characters"

Actions #3

Updated by Daniel Weeber over 4 years ago

Problem is in /usr/local/share/mobile-broadband-provider-info/serviceproviders.xml
Line 3150 contains (),-

<name>T-Mobile(Telekom)</name>

If I change that to esp "TMobileTelekom" I can add a device w/o any problem.

Actions #4

Updated by Daniel Weeber over 4 years ago

Sorry for third answer, just found the service name check

/usr/local/www/interfaces_ppps_edit.php
Line 276

if ($_POST['provider'] && !is_domain($_POST['provider'])) {

is_domain() is why () is failing in the service-name

Actions #5

Updated by Kill Bill over 4 years ago

Yeah, the input validation makes zero sense, there's no user input there in the first place.

https://github.com/pfsense/pfsense/pull/3648

Actions #6

Updated by Kill Bill over 4 years ago

Merged.

Actions #7

Updated by Jim Pingle over 4 years ago

  • Status changed from New to Feedback
  • Target version set to 2.4.0
Actions #8

Updated by Jim Pingle over 4 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF