Bug #6920: Upgrading to 2.4 with a stale package .inc file can prevent the system from fully booting after upgrade - pfSense - pfSense bugtracker

Bug #6920

Upgrading to 2.4 with a stale package .inc file can prevent the system from fully booting after upgrade

Added by Jim Pingle over 1 year ago. Updated over 1 year ago.

Status:

Resolved

Priority:

Normal

Assignee:

Renato Botelho

Category:

Upgrade

Target version:

2.4.0

Start date:

11/11/2016

Due date:

% Done:

100%

Affected Version:

2.4

Affected Architecture:

All

Description

I upgraded a 2.3 VM that had recently had FreeRADIUS installed, but removed. The old freeradius.inc was somehow left behind.

When the system attempted to boot after the 2.4 upgrade it stopped partway through booting and presented a login prompt. Just above was this:

[11-Nov-2016 22:12:16 America/New_York] PHP Warning:  require_once(xmlrpc.inc): failed to open stream: No such file or directory in /usr/local/pkg/freeradius.inc on line 40
[11-Nov-2016 22:12:16 America/New_York] PHP Stack trace:
[11-Nov-2016 22:12:16 America/New_York] PHP   1. {main}() /etc/rc.bootup:0
[11-Nov-2016 22:12:16 America/New_York] PHP   2. filter_configure_sync() /etc/rc.bootup:217
[11-Nov-2016 22:12:16 America/New_York] PHP   3. filter_nat_rules_generate() /etc/inc/filter.inc:265
[11-Nov-2016 22:12:16 America/New_York] PHP   4. discover_pkg_rules() /etc/inc/filter.inc:2344
[11-Nov-2016 22:12:16 America/New_York] PHP   5. require_once() /etc/inc/filter.inc:4211
[11-Nov-2016 22:12:16 America/New_York] PHP Fatal error:  require_once(): Failed opening required 'xmlrpc.inc' (include_path='.:/etc/inc:/usr/local/www:/usr/local/captiveportal:/usr/local/pkg:/usr/local/www/classes:/usr/local/www/classes/Form:/usr/local/share/pear') in /usr/local/pkg/freeradius.inc on line 40

That file has been replaced/moved on 2.4 so the old reference is invalid. The package wasn't installed, so it wasn't reinstalled to get an updated copy.

We may want to sanity check that there aren't any files present in /usr/local/pkg/ which might reference xmlrpc.inc or other removed files.

Associated revisions

Revision 87913c30
Added by Renato Botelho over 1 year ago

Fix #6920: Do not include stale .inc files

Packages can declare a function called $pkgname_generate_rules() and it
will be executed during filter reload process and add the hability to
package insert necessary firewall rules. Code was listing all files
/usr/local/pkg/*.inc and processing all of them without any kind of
check, what lead to the error reported in #6920.

Change the code to read only .inc files that belongs to currently
installed packages.

Revision fef29f5a
Added by Renato Botelho over 1 year ago

Fix #6920: Do not include stale .inc files

Change the code to read only .inc files that belongs to currently
installed packages.

Revision 6522505c
Added by Renato Botelho over 1 year ago

Ticket #6920: Use filter_rule_function tag to detect function name