Project

General

Profile

Bug #6950

Auto Config Backup always reports success

Added by Steve Wheeler 6 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Category:
AutoConfigBackup
Target version:
Start date:
11/22/2016
Due date:
% Done:

100%

Affected version:
All
Affected Architecture:
All

Description

The 'Backup Now' function always reports 'Backup completed successfully.' even if the backup to the server failed. If the login credentials are bad for example.

It would be better to report the actual logged output there since that function is really only used for diagnostic purposes. Incorrectly reporting success is just confusing.

History

#1 Updated by Jim Thompson 6 months ago

  • Assignee set to Steve Beaver

#2 Updated by Kill Bill 5 months ago

I just removed the misleading "success" noise as part of https://github.com/pfsense/FreeBSD-ports/pull/234 - as noted there, there's nothing relevant to check for success in the code there. Any status reporting would need to be done elsewhere.

#3 Updated by Kill Bill 5 months ago

Well, actually there's some output needed no matter what, to provide some indication that the Backup button works. Redid the thing checking for write_config() result, that should at least report a failure for users with user-config-readonly priv.

#4 Updated by Renato Botelho 5 months ago

  • Status changed from New to Feedback
  • Assignee changed from Steve Beaver to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#5 Updated by Kill Bill 5 months ago

Works (at least for cases where write_config() returns false, and there's not really much else that could be done here.)

#6 Updated by Renato Botelho 5 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF