Auto Config Backup always reports success
The 'Backup Now' function always reports 'Backup completed successfully.' even if the backup to the server failed. If the login credentials are bad for example.
It would be better to report the actual logged output there since that function is really only used for diagnostic purposes. Incorrectly reporting success is just confusing.
- Assignee set to Steve Beaver
Well, actually there's some output needed no matter what, to provide some indication that the Backup button works. Redid the thing checking for write_config() result, that should at least report a failure for users with user-config-readonly priv.
- Status changed from New to Feedback
- Assignee changed from Steve Beaver to Renato Botelho
- % Done changed from 0 to 100
PR has been merged. Thanks!
Works (at least for cases where write_config() returns false, and there's not really much else that could be done here.)
- Status changed from Feedback to Resolved
Also available in: Atom