Project

General

Profile

Actions
Copy link

Bug #6950

closed
SW RB

Auto Config Backup always reports success

Bug #6950: Auto Config Backup always reports success

Added by Steve Wheeler almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
AutoConfigBackup
Target version:
pfSense - 2.4.0
Start date:
11/22/2016
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Affected Version:
All
Affected Plus Version:
Affected Architecture:
All

Description

The 'Backup Now' function always reports 'Backup completed successfully.' even if the backup to the server failed. If the login credentials are bad for example.

It would be better to report the actual logged output there since that function is really only used for diagnostic purposes. Incorrectly reporting success is just confusing.

JT Updated by Jim Thompson almost 10 years ago Actions
Copy link
 #1

  • Assignee set to Anonymous

KB Updated by Kill Bill over 9 years ago Actions
Copy link
 #2

I just removed the misleading "success" noise as part of https://github.com/pfsense/FreeBSD-ports/pull/234 - as noted there, there's nothing relevant to check for success in the code there. Any status reporting would need to be done elsewhere.

KB Updated by Kill Bill over 9 years ago Actions
Copy link
 #3

Well, actually there's some output needed no matter what, to provide some indication that the Backup button works. Redid the thing checking for write_config() result, that should at least report a failure for users with user-config-readonly priv.

RB Updated by Renato Botelho over 9 years ago Actions
Copy link
 #4

  • Status changed from New to Feedback
  • Assignee changed from Anonymous to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

KB Updated by Kill Bill over 9 years ago Actions
Copy link
 #5

Works (at least for cases where write_config() returns false, and there's not really much else that could be done here.)

RB Updated by Renato Botelho over 9 years ago Actions
Copy link
 #6

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom