Bug #6950
closed
Auto Config Backup always reports success
100%
Description
The 'Backup Now' function always reports 'Backup completed successfully.' even if the backup to the server failed. If the login credentials are bad for example.
It would be better to report the actual logged output there since that function is really only used for diagnostic purposes. Incorrectly reporting success is just confusing.
Updated by
Updated by Kill Bill about 8 years ago
I just removed the misleading "success" noise as part of https://github.com/pfsense/FreeBSD-ports/pull/234 - as noted there, there's nothing relevant to check for success in the code there. Any status reporting would need to be done elsewhere.
Updated by Kill Bill about 8 years ago
Well, actually there's some output needed no matter what, to provide some indication that the Backup button works. Redid the thing checking for write_config() result, that should at least report a failure for users with user-config-readonly priv.
Updated by Renato Botelho about 8 years ago
- Status changed from New to Feedback
- Assignee changed from Anonymous to Renato Botelho
- % Done changed from 0 to 100
PR has been merged. Thanks!
Updated by Kill Bill almost 8 years ago
Works (at least for cases where write_config() returns false, and there's not really much else that could be done here.)
Updated by Renato Botelho almost 8 years ago
- Status changed from Feedback to Resolved