Project

General

Profile

Bug #6969

Insufficient error checking on static ARP entries

Added by Steve Wheeler 10 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
11/28/2016
Due date:
% Done:

100%

Affected version:
All
Affected Architecture:
All

Description

When creating a static DHCP lease entry the GUI input checking does not prevent checking 'static ARP' without entering an IP address.
This results in an invalid entry and subsequent log entries like:

Nov 28 16:45:34 php-fpm 49556 /services_dhcp.php: The command '/usr/sbin/arp -s '' '00:06:b2:f2:1c:a6'' returned exit code '1', the output was 'arp: : Unknown server error'

Associated revisions

Revision 7a9c12b3
Added by Jim Pingle 10 months ago

Improve input validation on static ARP for DHCP static mapping entries, also prevent the backend from attempting to apply entries with insufficient information stored. Fixes #6969

History

#1 Updated by Jim Pingle 10 months ago

  • Status changed from New to Confirmed

Adding a note to clarify: It is OK for "IP address" to be blank/empty if "ARP Table Static Entry" is unchecked.

#2 Updated by Jim Thompson 10 months ago

  • Assignee set to Jim Pingle

#3 Updated by Jim Pingle 10 months ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

#4 Updated by Jim Pingle 10 months ago

  • Assignee changed from Jim Pingle to Steve Wheeler

#5 Updated by Steve Wheeler 10 months ago

Seems fixed in todays 2.4 snapshots.
It won't allow the static DHCP lease to be submitted and the error message gives useful information.

#6 Updated by Jim Pingle 10 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF