Project

General

Profile

Actions
Copy link

Bug #6976

closed
SP RB

Interface group and alias with same name creates firewall syntax error

Bug #6976: Interface group and alias with same name creates firewall syntax error

Added by Sander Peterse almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
Web Interface
Target version:
2.3.3
Start date:
11/30/2016
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3.2
Affected Architecture:

Description

The firewall fails to reload when using the same name for an alias and interface group.

Steps to reproduce:
1. Create interface group with name "TestFirewall" assign atleast one interface.
2. Create alias with name "TestFirewall", for example to IP 8.8.8.8
3. Create a filewall rule on the interface group "TestFirewall" and use the alias "TestFirewall" in this rule.
4. Reload the firewall (apply config changes).
5. PFSense will report a syntax error (red alert icon in the right top of the webinterface).

JP Updated by Jim Pingle almost 10 years ago Actions
Copy link
 #1

  • Category set to Web Interface
  • Status changed from New to Confirmed
  • Assignee set to Anonymous
  • Target version set to 2.4.0

This is also a problem on 2.4.

Input validation should prevent an alias from using a name that is already an interface or group name, and it should also prevent an interface group from using a name used by aliases.

/interfaces_groups_edit.php

- DOES prevent a group name from overlapping an existing interface - This is OK
- DOES NOT prevent a group name from overlapping an alias - This must be fixed

/firewall_aliases_edit.php

- DOES NOT prevent an alias name from overlapping an existing interface (e.g. WAN, OPT1) - This must be fixed
- DOES NOT prevent an alias name from overlapping an interface group name - This must be added

RB Updated by Renato Botelho almost 10 years ago Actions
Copy link
 #2

  • Assignee changed from Anonymous to Renato Botelho

I'll handle it

RB Updated by Renato Botelho almost 10 years ago Actions
Copy link
 #3

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:7ec6e2831fe56514e90fcbd2beb5af52b7054ab6.

JP Updated by Jim Pingle over 9 years ago Actions
Copy link
 #4

  • Status changed from Feedback to Resolved

All of the problem cases work as expected now. Names are rejected as being in use, I was not able to make a conflict.

JP Updated by Jim Pingle over 9 years ago Actions
Copy link
 #5

  • Target version changed from 2.4.0 to 2.3.3
Actions
Copy link

Also available in: Atom