Project

General

Profile

Bug #7190

pfSense-pkg-acme Bug - php errors on pages that list certificates when no LE Certs have been created yet (eg Cert. Manager - Certificates, OpenVPN - Servers)

Added by Greg Siemon over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
ACME
Target version:
-
Start date:
02/01/2017
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.4
Affected Architecture:

Description

I just installed pfSense-pkg-acme and went to the Cert. Manager - Certificates Page. I see the following output immediately above the certificate list. It looks like its trying to iterate through an empty array as no LE certs have been created yet. This error is also seen on any page that lists certificates (eg OpenVPN, etc).

Cert.Manager - Certificates

Warning: Invalid argument supplied for foreach() in /usr/local/pkg/acme/acme.inc on line 30 Call Stack: 0.0001 230472 1. {main}() /usr/local/www/system_certmanager.php:0 0.2633 5004096 2. pkg_call_plugins() /usr/local/www/system_certmanager.php:968 0.5550 5067536 3. call_user_func:{/etc/inc/pfsense-utils.inc:3172}() /etc/inc/pfsense-utils.inc:3172 0.5551 5067600 4. acme_plugin_certificates() /etc/inc/pfsense-utils.inc:3172

In OpenVPN - Servers - Server_Name

Warning: Invalid argument supplied for foreach() in /usr/local/pkg/acme/acme.inc on line 30 Call Stack: 0.0003 232872 1. {main}() /usr/local/www/vpn_openvpn_server.php:0 0.6427 5094808 2. openvpn_build_cert_list() /usr/local/www/vpn_openvpn_server.php:835 0.6436 5096664 3. cert_in_use() /etc/inc/openvpn.inc:245 0.6439 5096856 4. is_package_cert() /etc/inc/certs.inc:773 0.6439 5097456 5. pkg_call_plugins() /etc/inc/certs.inc:741 0.9109 5158032 6. call_user_func:{/etc/inc/pfsense-utils.inc:3172}() /etc/inc/pfsense-utils.inc:3172 0.9110 5158096 7. acme_plugin_certificates() /etc/inc/pfsense-utils.inc:3172 Warning: Invalid argument supplied for foreach() in /usr/local/pkg/acme/acme.inc on line 30 Call Stack: 0.0003 232872 1. {main}() /usr/local/www/vpn_openvpn_server.php:0 0.6427 5094808 2. openvpn_build_cert_list() /usr/local/www/vpn_openvpn_server.php:835 0.9257 5152592 3. cert_in_use() /etc/inc/openvpn.inc:245 0.9259 5152592 4. is_package_cert() /etc/inc/certs.inc:773 0.9260 5153128 5. pkg_call_plugins() /etc/inc/certs.inc:741 1.1695 5153488 6. call_user_func:{/etc/inc/pfsense-utils.inc:3172}() /etc/inc/pfsense-utils.inc:3172 1.1695 5153520 7. acme_plugin_certificates() /etc/inc/pfsense-utils.inc:3172 Warning: Invalid argument supplied for foreach() in /usr/local/pkg/acme/acme.inc on line 30 Call Stack: 0.0003 232872 1. {main}() /usr/local/www/vpn_openvpn_server.php:0 0.6427 5094808 2. openvpn_build_cert_list() /usr/local/www/vpn_openvpn_server.php:835 1.1821 5153312 3. cert_in_use() /etc/inc/openvpn.inc:245 1.1824 5153312 4. is_package_cert() /etc/inc/certs.inc:773 1.1824 5153848 5. pkg_call_plugins() /etc/inc/certs.inc:741 1.4256 5154192 6. call_user_func:{/etc/inc/pfsense-utils.inc:3172}() /etc/inc/pfsense-utils.inc:3172 1.4256 5154224 7. acme_plugin_certificates() /etc/inc/pfsense-utils.inc:3172

There's no category here for acme so I've left category unfilled for now.

Slightly OT. Is putting this under Services the best place to install it? I initally assumed it would be available under Cert. Manager as a subtab similar to how the OpenVPN Client Export package inserts itself into the VPN - OpenVPN pages and was surprised it wasn't there.

History

#2 Updated by Jim Thompson over 3 years ago

  • Category set to ACME
  • Assignee set to Jim Pingle

#3 Updated by Jim Pingle over 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Jim Pingle to Greg Siemon

PR was merged

#4 Updated by Greg Siemon over 3 years ago

Jim Pingle wrote:

PR was merged

Confirm fixed.

#5 Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF