Project

General

Profile

Actions
Copy link

Bug #7394

closed

firewall_aliases_edit.php: Renaming an alias after input errors fails to update references

Added by Jim Pingle over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Rules / NAT
Target version:
2.4.0
Start date:
03/15/2017
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

When renaming an alias the firewall normally checks for references in firewall/nat rules and updates the alias name where needed. This works fine when renaming to a valid new name. However, if the user submits an invalid name first, then fixes and resubmits, the rename action does not take place.

It looks like the alias' actual original name is lost on the second submission. $_POST['origname'] should always be the original name from the entry being edited but it appears to be getting overwritten with the submitted value, which confuses the rename process.

Actions
Copy link
 #2

Updated by Jim Pingle over 7 years ago

  • Status changed from New to Resolved
  • Assignee set to Jim Pingle

PR Was merged and tested

Actions
Copy link

Also available in: Atom PDF