Project

General

Profile

Bug #745

Interface groups cannot be named LAN, WAN or OPTx

Added by Mr Horizontal almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Interfaces
Target version:
Start date:
07/19/2010
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

You can't name an interface group as WAN, LAN, or OPTx because the rules are associated by the interface identifier (wan, lan, opt1, etc.) which do not (and shouldn't) change when the interface is renamed. Maybe append interface groups association with 'group', so LAN becomes 'langroup'? Or add input validation to not allow naming groups as LAN, WAN, or OPTx.

select.jpg (72.8 KB) select.jpg select Mr Horizontal, 07/26/2010 08:39 PM
in_rule.jpg (200 KB) in_rule.jpg in rule Mr Horizontal, 07/26/2010 08:39 PM

Associated revisions

Revision 4a71c087 (diff)
Added by Ermal Luçi almost 9 years ago

Fixes #745. Validate group name against existing interfaces.

History

#1 Updated by Chris Buechler almost 9 years ago

  • Status changed from New to Feedback

2 moved to #746

1. I don't see, if you edit a rule that's assigned to a group, it stays with that group. If you edit a rule on an interface, it stays on that interface. I don't see any scenario where the interface is wrong.

#2 Updated by Mr Horizontal almost 9 years ago

Just updated to latest snap (previously had Jun 15 where I noticed this issue), and it's still there.

This probably due to my dodgy naming of the Interface Group. My LAN interfaces are called GBIT, 100M and WIFI, and the group itself is called LAN...

See here when I go to the rules table page (select.jpg) and when in the rule (in_rule.jpg)

#3 Updated by Chris Buechler almost 9 years ago

  • Subject changed from Interface Group GUI niggles to Interface groups cannot be named LAN, WAN or OPTx
  • Status changed from Feedback to New

original updated with actual issue.

#4 Updated by Mr Horizontal almost 9 years ago

Confirm the renaming resolves the selection issue, and sorry for being a numpty naming it as such!

That said, can you add a small validator on the Interface Group creation page in assign interfaces to just ensure that groups aren't named with such illegal names?

#5 Updated by Ermal Luçi almost 9 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#6 Updated by Chris Buechler almost 9 years ago

  • Status changed from Feedback to Resolved

fixed

Also available in: Atom PDF